Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genpolicy: use root path from cbl-mariner Guest VM #8836

Merged

Conversation

danmihai1
Copy link
Contributor

Adjust genpolicy-settings.json to match the container root path from the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these issues in the future.

Fixes: #8835

Adjust genpolicy-settings.json to match the container root path from
the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of
Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these
issues in the future.

Fixes: kata-containers#8835

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
@danmihai1
Copy link
Contributor Author

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, in order to allow you to proceed with the tests.

We need to think, though, what's the best way to have this one sorted out for the generic case.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me in the short-term. Thanks

@fidencio fidencio merged commit 147d5fd into kata-containers:main Jan 17, 2024
183 of 199 checks passed
@danmihai1 danmihai1 deleted the danmihai1/test-with-cbl-mariner branch January 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools: genpolicy: cbl-mariner: container root path is incorrect
4 participants