Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: genpolicy: cbl-mariner: container root path is incorrect #8835

Closed
danmihai1 opened this issue Jan 15, 2024 · 0 comments · Fixed by #8836
Closed

tools: genpolicy: cbl-mariner: container root path is incorrect #8835

danmihai1 opened this issue Jan 15, 2024 · 0 comments · Fixed by #8836
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@danmihai1
Copy link
Member

danmihai1 commented Jan 15, 2024

As a step towards testing genpolicy for CoCo, we should start by testing policies generated by this tool on cbl-mariner Guest VMs. Testing cbl-mariner on AKS might be easier than testing using a different Guest that supports AGENT_POLICY=yes, because my team at Microsoft is already testing on cbl-mariner.

genpolicy expects a container Rootfs path similar to:

/run/kata-containers/shared/containers/d5dff9a64f2e096c0ebbfbc2daab5da2a6975c83e231cf03f33c4561a8cf5e85

That path is incorrect for Kata main branch + cbl-mariner Guest VMs, and that blocks the testing described above. The actual path is similar to:

/run/kata-containers/shared/containers/d5dff9a64f2e096c0ebbfbc2daab5da2a6975c83e231cf03f33c4561a8cf5e85/rootfs

@danmihai1 danmihai1 added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jan 15, 2024
danmihai1 added a commit to microsoft/kata-containers that referenced this issue Jan 15, 2024
Adjust genpolicy-settings.json to match the container root path from
the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of
Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these
issues in the future.

Fixes: kata-containers#8835

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Jan 15, 2024
danmihai1 added a commit to microsoft/kata-containers that referenced this issue Jan 16, 2024
Adjust genpolicy-settings.json to match the container root path from
the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of
Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these
issues in the future.

Fixes: kata-containers#8835

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
danmihai1 added a commit to microsoft/kata-containers that referenced this issue Jan 17, 2024
Adjust genpolicy-settings.json to match the container root path from
the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of
Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these
issues in the future.

Fixes: kata-containers#8835

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
danmihai1 added a commit to microsoft/kata-containers that referenced this issue Jan 20, 2024
Adjust genpolicy-settings.json to match the container root path from
the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of
Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these
issues in the future.

Fixes: kata-containers#8835

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
c3d pushed a commit to c3d/kata-containers that referenced this issue Feb 23, 2024
Adjust genpolicy-settings.json to match the container root path from
the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of
Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these
issues in the future.

Fixes: kata-containers#8835

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Development

Successfully merging a pull request may close this issue.

1 participant