Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: Add NVIDIA GPU Confidential kernel target #8872

Merged
merged 1 commit into from Jan 23, 2024

Conversation

zvonkok
Copy link
Contributor

@zvonkok zvonkok commented Jan 22, 2024

This is a follow up to the work of minimizing targets, unifying TDX,SNP builds for NVIDIA GPUs

Fixes: #8828

Follow-up PR will remove the old targets.

@katacontainersbot katacontainersbot added the size/small Small and simple task label Jan 22, 2024
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zvonkok!

zvonkok added a commit to zvonkok/kata-containers that referenced this pull request Jan 22, 2024
Remove the old SNP, TDX GPU related targets we no rely on kata-containers#8872

Fixes:  kata-containers#8873

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok zvonkok added no-backport-needed area/gpu Issues specific to GPU/PCIe labels Jan 22, 2024
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

This is a follow up to the work of minimizing targets, unifying TDX,SNP builds for NVIDIA GPUs

Fixes: kata-containers#8828

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok
Copy link
Contributor Author

zvonkok commented Jan 22, 2024

/test

@gkurz gkurz merged commit 4516f38 into kata-containers:main Jan 23, 2024
284 of 294 checks passed
zvonkok added a commit to zvonkok/kata-containers that referenced this pull request Jan 23, 2024
Remove the old SNP, TDX GPU related targets we no rely on kata-containers#8872

Fixes:  kata-containers#8873

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok added a commit to zvonkok/kata-containers that referenced this pull request Jan 23, 2024
Remove the old SNP, TDX GPU related targets we no rely on kata-containers#8872

Fixes:  kata-containers#8873

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok
Copy link
Contributor Author

zvonkok commented Jan 23, 2024

FYI @cdesiniotis @tariq1890 @shivamerla

zvonkok added a commit to zvonkok/kata-containers that referenced this pull request Feb 5, 2024
Remove the old SNP, TDX GPU related targets we no rely on kata-containers#8872

Fixes:  kata-containers#8873

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gpu Issues specific to GPU/PCIe ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpu: Add NVIDIA GPU Confidential kernel target
7 participants