Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: Remove the old SNP, TDX targets #8874

Closed
wants to merge 1 commit into from

Conversation

zvonkok
Copy link
Contributor

@zvonkok zvonkok commented Jan 22, 2024

Remove the old SNP, TDX GPU related targets we no rely on #8872

Fixes: #8873

@katacontainersbot katacontainersbot added the size/small Small and simple task label Jan 22, 2024
@zvonkok zvonkok added no-backport-needed area/gpu Issues specific to GPU/PCIe labels Jan 22, 2024
@zvonkok zvonkok marked this pull request as draft January 22, 2024 14:51
@zvonkok zvonkok marked this pull request as ready for review January 23, 2024 08:30
@zvonkok zvonkok force-pushed the nvidia-gpu-cleanup branch 2 times, most recently from 309332a to cbaf844 Compare January 23, 2024 08:48
@zvonkok
Copy link
Contributor Author

zvonkok commented Jan 23, 2024

/test

@zvonkok
Copy link
Contributor Author

zvonkok commented Jan 23, 2024

FYI @cdesiniotis @tariq1890 @shivamerla

@fidencio
Copy link
Member

So, just to make it clear for the maintainers, all the tests are going to fail as we're removing a build target.
This is expected, and someone will have to mark the checks as non-required and then as required again.

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zvonkok!

zvonkok added a commit to zvonkok/kata-containers that referenced this pull request Jan 24, 2024
Lets remove the GHA target actions first so the the follow-up PR kata-containers#8874 tests are succeeding.

Fixes: kata-containers#8900

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok
Copy link
Contributor Author

zvonkok commented Feb 5, 2024

/test

Remove the old SNP, TDX GPU related targets we no rely on kata-containers#8872

Fixes:  kata-containers#8873

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok
Copy link
Contributor Author

zvonkok commented Feb 13, 2024

Closing in favour #9026

@zvonkok zvonkok closed this Feb 13, 2024
c3d pushed a commit to c3d/kata-containers that referenced this pull request Feb 23, 2024
Lets remove the GHA target actions first so the the follow-up PR kata-containers#8874 tests are succeeding.

Fixes: kata-containers#8900

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gpu Issues specific to GPU/PCIe ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpu: Remove the old SNP, TDX targets
4 participants