Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: move attestation tests to run-k8s-tests-coco-nontee #9490

Merged

Conversation

wainersm
Copy link
Contributor

The new run-k8s-tests-coco-nontee job should be the home of attestation tests.

Changed run-k8s-tests-coco-nontee to get KBS installed and by the time the KBS variable is exported in the environment then the attestation tests will kick in (likewise they will skip in run-k8s-tests-on-aks).

Fixes #9455
Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com

@wainersm wainersm added area/ci Issues affecting the continuous integration area/confidential-containers Issues related to confidential containers (see also CCv0 branch) labels Apr 16, 2024
@katacontainersbot katacontainersbot added the size/small Small and simple task label Apr 16, 2024
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stevenhorsman stevenhorsman added force-skip-ci Stop the CI running for a PR (remember: if you break it, you fix it!) ok-to-test labels Apr 19, 2024
@stevenhorsman
Copy link
Member

Added force-skip-ci as this is a workflow update, so won't be reflected in the test run.

@stevenhorsman stevenhorsman removed the force-skip-ci Stop the CI running for a PR (remember: if you break it, you fix it!) label Apr 19, 2024
@stevenhorsman
Copy link
Member

/test

@stevenhorsman
Copy link
Member

Hey @wainersm - the self-hoster runner build checks are running on this. I thought it might be a mistake in the logic and force-skip-ci was meaning it didn't get run, but I've removed it and it's still not working. Maybe it's worth rebasing to see if that helps?

Copy link
Member

@c3d c3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The new run-k8s-tests-coco-nontee job should be the home of attestation
tests.

Changed run-k8s-tests-coco-nontee to get KBS installed and by the time the
KBS variable is exported in the environment then the attestation tests
will kick in (likewise they will skip in run-k8s-tests-on-aks).

Fixes kata-containers#9455
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
@wainersm wainersm force-pushed the port_attestation_nontee_job branch from fbd43e0 to 1e35291 Compare April 19, 2024 17:52
@wainersm
Copy link
Contributor Author

Only rebased to main as @stevenhorsman (thanks!) suggested!

@stevenhorsman
Copy link
Member

/test

@stevenhorsman stevenhorsman merged commit ff9985f into kata-containers:main Apr 22, 2024
298 of 304 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues affecting the continuous integration area/confidential-containers Issues related to confidential containers (see also CCv0 branch) ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: move attestation tests to the new non-TEE CoCo jobs
5 participants