This repository has been archived by the owner on May 12, 2021. It is now read-only.
Allow kata-deploy containers to restart gracefully #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krsna1729 ptal wdyt |
|
Thanks @brtknr - I know you are now swatting up on the contributors guide, and will be updating the patch/PR format to make the CIs happy. If you need any input on that, just ask. |
brtkwr
changed the title
brtkwr
changed the title
|
Yup will help make it idempotent |
|
We could also check for the label early on and go to sleep |
egernst
approved these changes
May 6, 2019
|
/test |
|
Hi @egernst, what fix in the commit message are you referring to? |
If the container has had to restart, lack of overwrite here causes a benign error message to appear since the nodes already have `katacontainers.io/kata-runtime=true` label. Having a overwrite here means that we don't get the following error message:
error: 'katacontainers.io/kata-runtime' already has a value (true), and --overwrite is false
Signed-off-by: Bharat Kunwar <b.kunwar@gmail.com>
|
/test |
jodh-intel
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the containers deployed by kata-deploy.yaml have had to restart, lack of overwrite here causes a benign error message to appear since the nodes already have
katacontainers.io/kata-runtime=truelabel. Having a overwrite here means that we don't get the following error message in the logs and prevent the deployment to fail needlessly: