Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

The makefile does not contain all the generated vars in USER_VARS #2943

Closed
c3d opened this issue Sep 10, 2020 · 1 comment
Closed

The makefile does not contain all the generated vars in USER_VARS #2943

c3d opened this issue Sep 10, 2020 · 1 comment
Assignees
@c3d
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog

Comments

@c3d
Copy link
Member

c3d commented Sep 10, 2020

Description of problem

The list in USER_VARS does not match the list of sed replacements in the rule for $(GENERATED_FILES).

For example, KERNELPATH or DEFNETWORKMODEL_CLH are in the generated list but not in USER_VARS.

As a result, make show-variables does not show all variables.
@c3d c3d added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Sep 10, 2020
@c3d c3d self-assigned this Sep 10, 2020
@c3d
Copy link
Member Author

c3d commented Sep 10, 2020

I suggest replacing the long duplicate and error-prone list in $(GENERATED_FILES) rule with:

GENERATED_VARS = \
		VERSION \
		CONFIG_ACRN_IN \
		CONFIG_QEMU_IN \
		CONFIG_QEMU_VIRTIOFS_IN \
		CONFIG_CLH_IN \
		CONFIG_FC_IN \
		$(USER_VARS)

$(GENERATED_FILES): %: %.in $(MAKEFILE_LIST) VERSION .git-commit
	$(QUIET_GENERATE)$(SED) \
		-e "s|@COMMIT@|$(shell cat .git-commit)|g" \
		$(foreach v,$(GENERATED_VARS),-e "s|@$v@|$($v)|g") \
		$< > $@

@jodh-intel jodh-intel added this to To do in Issue backlog Sep 18, 2020
@jodh-intel jodh-intel moved this from To do to In progress in Issue backlog Sep 18, 2020
c3d added a commit to c3d/runtime that referenced this issue Oct 9, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
2a6c127 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 9, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
3007777 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 9, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
0c67c0d 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
@c3d c3d mentioned this issue Oct 12, 2020
Closed
c3d added a commit to c3d/kata-containers that referenced this issue Oct 12, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
c2db6d0 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
@c3d c3d mentioned this issue Oct 12, 2020
Merged
c3d added a commit to c3d/kata-containers that referenced this issue Oct 12, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
abed593 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/kata-containers that referenced this issue Oct 12, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
f190c69 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 12, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
0f2d614 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/kata-containers that referenced this issue Oct 14, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
63628a5 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 14, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
c926f3d 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/kata-containers that referenced this issue Oct 14, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
966bd57 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 16, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
5def222 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 16, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
53c92df 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
bergwolf pushed a commit to bergwolf/kata-containers that referenced this issue Oct 17, 2020
@c3d @bergwolf
makefile: Add missing generated vars to USER_VARS
d9c8728 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
bergwolf pushed a commit to bergwolf/kata-containers that referenced this issue Oct 17, 2020
@c3d @bergwolf
makefile: Add missing generated vars to USER_VARS
cf45909 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
bergwolf pushed a commit to bergwolf/kata-containers that referenced this issue Oct 17, 2020
@c3d @bergwolf
makefile: Add missing generated vars to USER_VARS
134152c 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
bergwolf pushed a commit to bergwolf/kata-containers that referenced this issue Oct 17, 2020
@c3d @bergwolf
makefile: Add missing generated vars to USER_VARS
451608f 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 19, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
a23f4ee 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 19, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
377b617 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 21, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
16753bb 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 22, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
aa594b9 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Oct 27, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
4d0b2c0 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/runtime that referenced this issue Nov 5, 2020
@c3d
makefile: Add missing generated vars to USER_VARS
d1cb607 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Issue backlog automation moved this from In progress to Done Nov 11, 2020
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Nov 11, 2020
@c3d @fidencio
makefile: Add missing generated vars to USER_VARS
7a6cd2a 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
@jodh-intel jodh-intel moved this from Done to In progress in Issue backlog Nov 11, 2020
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Nov 11, 2020
@c3d @fidencio
makefile: Add missing generated vars to USER_VARS
4eb0029 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

Fixes: kata-containers#2943
Fixes: kata-containers#3004

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to kata-containers/kata-containers that referenced this issue Apr 12, 2021
@c3d
makefile: Add missing generated vars to USER_VARS
ebd4da6 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: #901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d added a commit to c3d/kata-containers that referenced this issue Apr 12, 2021
@c3d
makefile: Add missing generated vars to USER_VARS
081b196 
This was discovered while checking a massive change in variables.
The root cause for the error is a very long list of manual
replacements, that is best replaced with a $(foreach).

All individual variables in the output configuration files were
checked against the old build using diff.

This is a forward port of a makefile fix included in
PR kata-containers/runtime#3004
for issue kata-containers/runtime#2943

Fixes: kata-containers#901

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@c3d c3d

Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c3d