-
Notifications
You must be signed in to change notification settings - Fork 195
CI: Disable root tests in dev mode #30
CI: Disable root tests in dev mode #30
Conversation
Hi @chavafg, @sameo, @sboeuf, @grahamwhaley, @bergwolf - what do you think? If we decide that developers really do want to run tests as But it should be considered very unsafe for a developer to set |
I agree that developers should not run the tests as root. |
@chavafg - I agree. We need a |
See #32. |
Could we get one more review on this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the README will now be a necessity - the combinatorics are getting complex.
One minor nit, but, given this is what we want to do then:
lgtm
.ci/go-test.sh
Outdated
users="current root" | ||
if [ -n "$KATA_DEV_MODE" ]; then | ||
warn "Dangerous to set CI with KATA_DEV_MODE set" | ||
warn "Not also running tests as root" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rephrase this line - it doesn't quite make sense in my head....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - reworded for improved clarity.
Don't run the unit tests as root in developer mode (when `KATA_DEV_MODE`) is set. Fixes kata-containers#29. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
292997a
to
e74ded9
Compare
Don't run the unit tests as root in developer mode (when
KATA_DEV_MODE
) is set.Fixes #29.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com