Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Change xurls url #836

Closed
wants to merge 1 commit into from
Closed

ci: Change xurls url #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/static-checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ check_docs()
if [ ! "$(command -v $cmd)" ]
then
info "Installing $cmd utility"
go get -u "mvdan.cc/xurls/cmd/$cmd"
go get -u "github.com/mvdan/${cmd}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - actually, this needs to be:

Suggested change
go get -u "github.com/mvdan/${cmd}"
go get -u "github.com/mvdan/xurls/cmd/${cmd}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I saw this last week, I could not make the github URL work. The 'mvdan.cc' site seemed to be temporarily down, and then came back up, and everything started working for me again, hence I didn't file a fix or dig deeper on how to make the github URLs work.

fi

info "Checking documentation"
Expand Down