New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Change xurls url #836
ci: Change xurls url #836
Conversation
xurls repo url is not being resolved. Switch to the github url. Fixes: kata-containers#835. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
/test |
1 similar comment
/test |
Raised kata-containers/ci#74 for the ARM CI failure (which appears unrelated to this PR). lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. I saw this failure a week or two ago, tried that URL change fix locally, and it did not work....
Given most of the CIs seem happy....
lgtm
@@ -385,7 +385,7 @@ check_docs() | |||
if [ ! "$(command -v $cmd)" ] | |||
then | |||
info "Installing $cmd utility" | |||
go get -u "mvdan.cc/xurls/cmd/$cmd" | |||
go get -u "github.com/mvdan/${cmd}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - actually, this needs to be:
go get -u "github.com/mvdan/${cmd}" | |
go get -u "github.com/mvdan/xurls/cmd/${cmd}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I saw this last week, I could not make the github URL work. The 'mvdan.cc' site seemed to be temporarily down, and then came back up, and everything started working for me again, hence I didn't file a fix or dig deeper on how to make the github URLs work.
We can't merge this until the xurls URL is corrected (oh the irony... 😄) |
... and the reason the CI tests passed here is that the So although |
In summary, this fix is urgent, but only new PRs that change documents will fail the CI stage until this PR lands. |
... errmm. Correction:
|
Yes. All PRs are blocked now. |
I'll raise a PR that replaces this one so we can resolve this "now"... |
Closing as replaced by #839. |
xurls repo url is not being resolved. Switch to
the github url.
Fixes: #835.
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com