Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Make static check ignore local URLs #838

Merged

Conversation

jodh-intel
Copy link
Contributor

Update the static check script to ignore file:// URLs which won't
exist (since they only appear in examples).

Fixes #837.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@jodh-intel
Copy link
Contributor Author

This is blocking kata-containers/documentation#272.

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Contributor Author

/test

@grahamwhaley
Copy link
Contributor

Now we have #839 (force) merged, let's tickle this and see if it worked....
/test

@grahamwhaley
Copy link
Contributor

Ah, maybe as this is a PR in the tests repo, it would need a rebase before it took on #839 :-(

/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/stress
versions.yaml
  7:1       warning  missing document start "---"  (document-start)

INFO: Installing xurls utility
package mvdan.cc/xurls/v2: cannot find package "mvdan.cc/xurls/v2" in any of:
	/usr/local/go/src/mvdan.cc/xurls/v2 (from $GOROOT)
	/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/mvdan.cc/xurls/v2 (from $GOPATH)
Build step 'Execute shell' marked build as failure

This PR was triggered for a rebuild, let's watch that one @jodh-intel and your newly kicked kata-containers/documentation#280 as well.....

@jodh-intel jodh-intel force-pushed the ci-static-check-ignore-file-urls branch from cd2051b to 38299fd Compare October 23, 2018 10:05
Update the static check script to ignore `file://` URLs which won't
exist (since they only appear in examples).

Fixes kata-containers#837.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the ci-static-check-ignore-file-urls branch from 38299fd to edf8474 Compare October 23, 2018 14:20
@jodh-intel
Copy link
Contributor Author

/test

@chavafg
Copy link
Contributor

chavafg commented Oct 23, 2018

saw some docker failures on the initrd job. Not related to this PR so relaunching job...

Summarizing 5 Failures:

[Fail] Hotplug memory when create containers Hotplug memory when create containers [It] hotplug memory when create containers should not fail 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/mem_test.go:74

[Fail] docker privileges [AfterEach] check no-new-privileges flag should display the correct uid 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/privileges_test.go:34

[Fail] docker volume remove bind-mount source before container exits [It] should exit cleanly without leaking process 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/volume_test.go:175

[Fail] load [AfterEach] load with docker load a container should load image 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/load_test.go:26

[Fail] docker commit commit a container with new configurations [It] should have the new configurations 
/tmp/jenkins/workspace/kata-containers-tests-ubuntu-16-04-PR-initrd/go/src/github.com/kata-containers/tests/integration/docker/commit_test.go:41

@jodh-intel
Copy link
Contributor Author

I'm going to suggest we just merge this:

  • the ARM CI failed but we know it's broken atm.
  • the jenkins-ci-ubuntu-16-04-initrd CI failed but the failure cannot be related to this PR which would only affect doc changes (of which there are none on this PR :)

Takers... ? :)

@jodh-intel
Copy link
Contributor Author

We'll then be unblocking kata-containers/documentation#272.

@chavafg
Copy link
Contributor

chavafg commented Oct 23, 2018

lgtm

Approved with PullApprove

@chavafg
Copy link
Contributor

chavafg commented Oct 23, 2018

pullapprove not working...
I'll merge as the ubuntu-initrd job has already passed and there are acks from @grahamwhaley and myself.

@chavafg chavafg merged commit 0341cc1 into kata-containers:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants