-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Make static check ignore local URLs #838
CI: Make static check ignore local URLs #838
Conversation
This is blocking kata-containers/documentation#272. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/test |
Now we have #839 (force) merged, let's tickle this and see if it worked.... |
Ah, maybe as this is a PR in the tests repo, it would need a rebase before it took on #839 :-(
This PR was triggered for a rebuild, let's watch that one @jodh-intel and your newly kicked kata-containers/documentation#280 as well..... |
cd2051b
to
38299fd
Compare
Update the static check script to ignore `file://` URLs which won't exist (since they only appear in examples). Fixes kata-containers#837. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
38299fd
to
edf8474
Compare
/test |
saw some docker failures on the initrd job. Not related to this PR so relaunching job...
|
I'm going to suggest we just merge this:
Takers... ? :) |
We'll then be unblocking kata-containers/documentation#272. |
pullapprove not working... |
Update the static check script to ignore
file://
URLs which won'texist (since they only appear in examples).
Fixes #837.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com