New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix xurls URL #839
CI: Fix xurls URL #839
Conversation
The `xurls` tool used by the static checker seems to have changed its URL so switch to the (hopefully more reliable!) github one. Fixes: kata-containers#835. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Replaces #836. |
/test |
ARM CI failure can be ignored for now as it's currently borked (kata-containers/ci#74). |
Boom boom boom... CI's not happy:
|
It looks like the CI scripts are using the current (incorrect) version of this script this PR changes so we're going to have to force-merge this one @grahamwhaley I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm prone to say.... it can't really make it any worse (or not right now).... and you tested the cmd locally to check it did actually pull the repo, so:
lgtm
go force @jodh-intel
Have forced - now let me go find another PR to tickle to check if it worked..... |
Undo URL change from [1] since the xurls install issue was caused by the CI using a version of golang that is too old for xurls. Fixes kata-containers#841. --- [1] - kata-containers#839 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Undo URL change from [1] since the xurls install issue was caused by the CI using a version of golang that is too old for xurls. Fixes kata-containers#841. --- [1] - kata-containers#839 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Undo URL change from [1] since the xurls install issue was caused by the CI using a version of golang that is too old for xurls. Fixes kata-containers#841. --- [1] - kata-containers#839 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
The
xurls
tool used by the static checker seems to have changed itsURL so switch to the (hopefully more reliable!) github one.
Fixes: #835.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com