Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go parser to identify blocks in Go files #44

Merged
merged 60 commits into from
Nov 2, 2021
Merged

Use Go parser to identify blocks in Go files #44

merged 60 commits into from
Nov 2, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 5, 2021

Use a Go parser to find Terraform blocks in Go acceptance test files. Identifies Go files by checking if the file name ends in .go and contains a line matching package [a-zA-Z0-9_]+\n.

Terraform blocks are identified as any string that contains a resource, data source,variable, or output declaration.

@gdavison
Updates dependencies to latest
767ae7f
@gdavison
Adds tests for Golang block detection
d8a9045
@gdavison
Adds tests for Markdown
787b04b
@gdavison
Updates dependencies
a08fb88
@gdavison
Adds tests for terrafmt blocks command
5b56dec
@gdavison
Adds tests for terrafmt diff command
50fdda4
@gdavison
Adds tests for terrafmt fmt command
f5624af
@gdavison
Adds tests for terrafmt upgrade012 command
b5a3c76
@gdavison
Replaces bytes.Buffer with strings.Builder
0627990
@gdavison
Adds noDiff case to fmt test
c9a2753
@gdavison
Adds noDiff case to upgrade012 test
6a5bb27
@gdavison
Renames Go test result files
06fdae7
@gdavison
Adds Markdown blocks tests
7d78e04
@gdavison
Adds Markdown diff tests
3519fcf
@gdavison
Adds Markdown fmt tests
9100d90
@gdavison
Adds Markdown upgrade012 tests
0a36daf
@gdavison
Actually set fix-finish-lines on Markdown test case
078fa63
@gdavison
Removes formatting directives from Markdown test cases
ee002b7
@gdavison
Adds testing for expected error messages
f8aef66
@gdavison
Cleans up test failure output for error message tests
2cb1b58
@gdavison
Adds Afero to abstract filesystem
2ea97bb
@gdavison
Adds filesystem tests for fmt command
6b38de5
@gdavison
Adds filesystem tests for upgrade012 command
2f14c46
@gdavison
Fix up
3f7dc8d
@gdavison
Updates Afero to be direct dependency
3607741
@gdavison
Renames test values
e4750ea
@gdavison
Adds tests for verbose flag on blocks command
3c087f1
@gdavison
Adds tests for verbose flag on diff command
310b83f
@gdavison
Adds tests for verbose flag on fmt command
c20717c
@gdavison
Adds tests for verbose flag on upgrade012 command
2c7320c
@gdavison
Removes Log as a global variable
a666303
@gdavison
Makes all cli tests parallel to speed them up.
e52232f
@gdavison
Updates dependencies to latest
2abd2f0
@gdavison
Adds golang block detection
6560e7b
@gdavison
Uses Go AST for blocks command
74727cd
@gdavison
Uses Go AST for diff command
1b47eb2
@gdavison
Uses Go AST for fmt command
4885a81
@gdavison
Uses Go AST for upgrade012 command. Currently has a diff if the for…
2801941 
…matting shortens the block
@gdavison
Adds const and composed cases to block detection
afa4bd9
@gdavison
Fix after rebase
7f108c0
@gdavison
Merge branch 'master' into use-parsers
20bebd9 
# Conflicts:
#	cli/blocks_test.go
#	cli/cmds.go
#	cli/diff_test.go
#	cli/fmt_test.go
#	cli/upgrade012_test.go
#	lib/blocks/blockreader.go
#	lib/blocks/blockreader_test.go
#	lib/blocks/testdata/test1.go
#	lib/blocks/testdata/test1_results.yaml
@gdavison
Adds Go astutil and fixes some upgrade012 issues
61e4af6
@gdavison
Adds check to see if candidate block looks like Terraform
8105566
@gdavison
Adds test for diff reporting
dfba683
@gdavison
Factors out command test cases
b941759
@gdavison
Handles blocks without padding better
802a1cd
@gdavison
Merge branch 'master' into use-parsers
da79540
@gdavison
Correctly handles blocks with leading spaces
5a96133
@gdavison
Fixes line endings
179d180
@gdavison
Adds tests for leading and trailing padding
511a7af
@gdavison
Merge branch 'main' into use-parsers
2b96167
@gdavison
Renames functions and cleans up unused Go pattern matching
8e3cba3
@gdavison gdavison mentioned this pull request Mar 30, 2021
Closed
katbyte
katbyte approved these changes Sep 16, 2021
View reviewed changes
Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏫

@katbyte katbyte added this to the v0.3.0 milestone Sep 16, 2021
@katbyte katbyte merged commit 7a42aba into katbyte:main Nov 2, 2021
@katbyte katbyte modified the milestones: v0.3.0, v0.4.0 Mar 22, 2022
@gdavison gdavison deleted the use-parsers branch May 5, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdavison @katbyte