-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the deprecated ScriptProcessorNode with AudioWorkletNode #1281
Comments
There's now also a polyfill available: https://github.com/GoogleChromeLabs/audioworklet-polyfill |
This looks promising as well: https://github.com/chrisguttandin/standardized-audio-context |
I came across AudioWorklets earlier today. From what I understand they could be used to play audio in a separate thread, so audio processing will never cause the UI to lag? I’m definitely going to look into this but I may need some help from people who know the web audio api better than me :) |
That's also my understanding yea. |
ScriptProcessorNode AudioWorkletNode |
Hi! iOS 14.5 is now released, which brings unprefixed WebAudio AND AudioWorklet support to Safari. Make sure to check that out. I guess in the future we will focus on AudioWorkletNode and provide ScriptProcessorNode as a fallback for iOS 14.4 and below (detected by webkit perfix WebAudio) |
Has any progress been made in regards to adding support for |
I'm waiting for an update, for music services very important support for AudioWorkletNode |
Please consider sponsoring one of the developers to implement this feature. |
@dvantage @cameronSlupeiks this will take a bit of time to implement properly. @sundayz if we do update to audioworkletnode we have to keep in mind using it will require a secure context making wavesurfer only work properly if its from a https resource when using webaudio.
|
@entonbiba any update on this? |
Any update on this. This issue has existed for well over a year with seemingly no progress or evidence that Wavesurfer intends to adopt this. |
I think this would be an excellent opensource or sponsors contribution. |
@Yan-vibeit I'll have a look at this again in the upcoming weeks see what's possible to implement it. |
On Sat, 25 Feb 2023 at 19:47, Enton Biba ***@***.***> wrote:
@Yan-vibeit <https://github.com/Yan-vibeit> I'll have a look at this
again in the upcoming weeks see what's possible to implement it.
—
Reply to this email directly, view it on GitHub
<#1281 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZGDEAREADLFRSF4L3D4HELWZJOVDANCNFSM4EJNOMMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
Thanks, it is much needed as the audio csn then run using a seperate thread
increasing performance. I appreciate you!
Yan.
|
I think this issue was closed accidentally - it should remain open unless tracked elsewhere, no? |
Feel free to reopen it, but the issue has been there for 5 years w/o any progress made, so I don't see the point of tracking it. Edit: reopened and clarified the title. |
@jgentes thanks for sponsoring btw! ❤️ |
You're welcome @katspaugh - this is certainly the one I am most interested in, but no, I just thought it was reasonable to send $1/mo your way for making such a great library. I'm using it for a personal project: https://github.com/jgentes/mixpoint |
Awesome! |
So, what is final the solution to remove this warning in wavesurfer.js? |
@sandokan815 the easiest is to just use Btw, ScriptProcessorNode seems to be used only for tracking the playback position when using the WebAudio backend. Should be fairly straightforward to replace. |
So get rid of the warning it is best to just use |
This warning will be gone completely in the next release. Edit: it's now live in 6.6.3. But yeah, |
I can confirm the warning is gone with setting webaudio.js:238 [Deprecation] The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead. (https://bit.ly/audio-worklet) |
ScriptProcessorNode
is deprecated from the specification and replaced withAudioWorklet
in Chrome 64. AudioWorklet is enabled by default for Chrome 66 or later. In Chrome 64 and 65, the feature is behind the experimental flag.See https://developers.google.com/web/updates/2017/12/audio-worklet and even better: https://developers.google.com/web/updates/2018/06/audio-worklet-design-pattern
The text was updated successfully, but these errors were encountered: