Ports from es5: Part two #1193
Merged
Ports from es5: Part two #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the call to `.empty()`when handling the resize of the container when `responsive`is set to `true`. This allow the playback to keep going while the container is resizing.
Should not close audiocontext when it's already closed. Chrome throws a warning if done so.
* add barHeight parameter * Update drawer.multicanvas.js * Update drawer.canvas.js
* add getFilters method * add getFilters() method add 'Filters must be set with setFilters method first' note. * return empty array if no filters are set * change to `return this.backend.filters || [];`
This was referenced Aug 19, 2017
Closed
|
BTW 4ee7aab fixes a bug that was introduced in the first half (incorrect implementation of |
|
Great, thanks! |
katspaugh
approved these changes
Aug 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds features and fixes that were added to the es5 branch (previously master) to the new master (previously next).
See #1092
First part: #1191