Mediaelement safari fixes #1964
Conversation
this was happening in the webaudio backend, but due to the odd inheritance layout of mediaelement-webaudio it wasn't happening here.
I felt the language used could be clearer and more accurate. |
|
@katspaugh can you add @osheroff to the team? I think he made some valuable contributions: https://github.com/katspaugh/wavesurfer.js/commits?author=osheroff |
Sure, good idea. Ben, I've sent you an invite. Many thanks for your work! |
|
off-topic, I was trying to figure out why all the builds were failing. I got down the rabbit hole so far as "something, somewhere, for some reason is adding a |
I added this yesterday, but local build was fine with it. See |
ah, mystery solved, this is one of those odd travis "merged with master" builds. got it. What's the merge policy here? 2 plus-ones? |
What do you mean? |
like, how many approvals do you want before a PR is merged? |
There is not really such a rule in this project. If you see a PR that is 99.99% correct to you, go ahead and merge it. If you have doubts, or just want someone to review your work, pick a couple of people and request a review. Hopefully someone responds soon and you can then merge it. If you open a PR that is trivial (doc/formatting changes), you can even merge it yourself afterwards (or commit direct to master but only if it's, like i said, trivial). Now that we add more and more people to the team it might make sense to have some formal policy at some point but for now it all seems to work out like this. |
I think it has improved @marizuccara. |
|
@thijstriemstra is it possible that this gets into a 3.x release? Or is the version 3 release line finished in favor of everything going towards the version 4 release? |
|
I think 4.0.0 can be released next week. |
* rewrite mediaelement-webaudio comment * resume audiocontext for Safari + mediaelement/webaudio this was happening in the webaudio backend, but due to the odd inheritance layout of mediaelement-webaudio it wasn't happening here. * add changelog entry * hoist common code into utility function * generalize comment
This fixes a condition where Safari was not playing with mediaelement/webaudio. It seems to implement the webaudio spec slightly differently than chrome and requires that you call AudioContext#resume().
I also rewrote the header comment into more natural english.
refs #1531