Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: avoid exit 1 in CI script #2734

Merged
merged 5 commits into from
Mar 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,20 @@ jobs:
NEW_VERSION=$(node -p 'require("./package.json").version')
if [ $NEW_VERSION != $OLD_VERSION ]; then
echo "New version $NEW_VERSION detected"
echo "::set-output name=version::$NEW_VERSION"
echo "version=$NEW_VERSION" >> $GITHUB_OUTPUT
git log "$OLD_VERSION"..HEAD --pretty=format:"* %s" > TEMP_CHANGELOG.md
else
echo "Version $OLD_VERSION hasn't changed, skipping the release"
exit 1
fi

- name: Create a git tag
if: success()
if: ${{ steps.version.outputs.version }}
run: git tag $NEW_VERSION && git push --tags
env:
NEW_VERSION: ${{ steps.version.outputs.version }}

- name: GitHub release
if: success()
if: ${{ steps.version.outputs.version }}
uses: actions/create-release@v1
id: create_release
with:
Expand All @@ -50,12 +49,18 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}

- uses: actions/setup-node@v3
if: ${{ steps.version.outputs.version }}
with:
node-version: '16.x'
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
if: success()
if: ${{ steps.version.outputs.version }}
run: npm install

- name: Publish to NPM
if: success()
if: ${{ steps.version.outputs.version }}
env:
NODE_AUTH_TOKEN: ${{ secrets.npm_token }}
run: npm publish
6 changes: 6 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
wavesurfer.js changelog
=======================

6.6.1 (18.03.2023)
------------------
- Fix: NPM publish in the CI job (#2727)
- Fix: avoid exit 1 in CI script (#2734)
- Docs: add a video tutorial link to the readme (#2724)

6.6.0 (14.03.2023)
------------------
- Zoom optimisation for Waves and matching implementation for Spectrograms (#2646)
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "wavesurfer.js",
"version": "6.6.0",
"version": "6.6.1",
"homepage": "https://wavesurfer-js.org",
"authors": [
"katspaugh <katspaugh@gmail.com>"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "wavesurfer.js",
"version": "6.6.0",
"version": "6.6.1",
"description": "Interactive navigable audio visualization using Web Audio and Canvas",
"main": "dist/wavesurfer.js",
"directories": {
Expand Down