Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android : Add bigview support #92

Closed
wants to merge 2 commits into from

Conversation

tdurand
Copy link

@tdurand tdurand commented Feb 10, 2014

Hi,

I did a small evolution to have a new feature on android, be able to display the notification as a big view:
http://developer.android.com/training/notify-user/expanded.html

To activate the option, you need to pass this new option when creating a notification:

notif.bigview = “true” 

Unfortunately i wasn’t able to use a proper boolean, when i do so, the options.optBoolean in the Options.java doesn’t get the true value, i don’t know why, you may be able to fix it.

Anyway, feel free to comment i can change some stuff.

Thibault

@katzer
Copy link
Owner

katzer commented Feb 12, 2014

Hello @tdurand,

thank you very much. I will take a look later.

The bigview property has to be added inside the applyPlatformSpecificOptions method in the JS file.

@tdurand
Copy link
Author

tdurand commented Feb 12, 2014

Ah okay... haven't seen that .. Anyway, when i have some time i will submit it again if you haven't corrected it yet.

@katzer katzer self-assigned this Feb 13, 2014
@katzer katzer added this to the v0.8.0 milestone Feb 15, 2014
@katzer katzer removed their assignment Feb 15, 2014
@katzer katzer added android and removed ios labels Mar 9, 2014
katzer added a commit that referenced this pull request Mar 9, 2014
@katzer
Copy link
Owner

katzer commented Mar 9, 2014

Hello @tdurand,

I have added the bigview support. But without the need for an extra flag.

@katzer katzer closed this Mar 9, 2014
@tdurand
Copy link
Author

tdurand commented Mar 10, 2014

well done, thanks for keeping up the good work with this plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants