Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I added the escaping for the newline char, as you suggested. Reading the specs here, it turned out that i also forgot to escape the textDelimiter if it's contained in the field, so i fixed that too.
However, as the spec says "Fields containing line breaks (CRLF), double quotes, and commas should be enclosed in double-quotes.", i don't know if i should hardcode these chars or run the check on the dynamic options fields (rowDelimiter and endOfLine). Or maybe both ? What do u think ?
It may be worth to note that the escaping occurs only if the json is an Object, i didn't changed the Array part of the lib, because i can't spend more time on it today.
Let me know if you need me to dig it deeper :)