Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix nested arrays with empty strings filled by the next array item #67

Merged
merged 2 commits into from
May 25, 2020

Conversation

kaue
Copy link
Owner

@kaue kaue commented May 23, 2020

Status

READY

Description

fixes #65, an issue with empty strings in nested arrays getting filled by the next array item
also includes a minor refactoring of fillRows function

Steps to Test or Reproduce

jsonexport([
    {
        "day": "1",
        "time": "12:00",
        "persons": [
            {
                "name": "Bob",
                "lastname": "Smith"
            },
            {
                "name": "James",
                "lastname": "piet"
            },
            {
                "name": "",
                "lastname": "Miller"
            },
            {
                "name": "David",
                "lastname": "Martin"
            }
        ]
    }
], (err, csv) => {});

fixes the issue with empty strings in nested arrays getting filled by
the next array item

also includes a minor refactoring of fillRows function
@kaue kaue mentioned this pull request May 23, 2020
@kaue kaue added this to the 3.0.0 milestone May 23, 2020
@kaue kaue changed the base branch from master to develop May 23, 2020 14:51
@kaue kaue mentioned this pull request May 23, 2020
3 tasks
@kaue kaue requested a review from AckerApple May 23, 2020 15:17
@AckerApple
Copy link
Collaborator

This new code is accurate for the issue we are chasing. Installed this branch into demo and tested there. Attaching results

image

day,time,persons.name,persons.lastname
1,12:00,Bob,Smith
,,James,piet
,,,Miller
,,David,Martin

Merging and will run deployment

@AckerApple AckerApple merged commit 4267267 into develop May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(I think I) found a bug
2 participants