Fix building using "make all" on macOS

[kaushalmodi]

@sshaw

The "eless build requirements" are higher than "eless run requirements".

For future plans like auto-publishing eless documentation site using ox-hugo, the minimum requirement for building eless script and documentation is emacs 24.4.. Couple of reasons:

• I use Org master (9.2.x), but can make sure that builds work fine on latest Org stable (9.1.x) too.. Minimum requirement for Org 9.1.x is emacs 24.4. So not worth trying to make the build process work on older emacs/Org versions.
• In the ox-hugo build setup, I use advice-add which got added in emacs 24.4.

From your comment in other thread:

make all EMACS=Emacs

 /tmp/eless >make all EMACS=Emacs
 Emacs binary used: Emacs
 Loading /tmp/eless/build/setup-eless.el (source)...
 Emacs is now refreshing its package database...
 Importing package-keyring.gpg...
 Importing package-keyring.gpg...done
 Contacting host: orgmode.org:443
 Failed to download ‘org’ archive.
 Failed to download ‘melpa’ archive.
 Package refresh done
 Installing ‘org-plus-contrib’ ..
 Setting ‘package-selected-packages’ temporarily since "emacs -q" would overwrite customizations
 Setting ‘package-selected-packages’ temporarily since "emacs -q" would overwrite customizations
 Package ‘org-plus-contrib-’ is unavailable
 make: *** [vcheck] Error 255

What emacs version was that?

The failure seems odd that it failed in the package download step itself.. http/https issues?

Let's first get make vcheck working on your system, emacs 24.4 or newer.

[sshaw]

make all EMACS=Emacs

/tmp/eless >Emacs --version
GNU Emacs 25.3.1
Copyright (C) 2017 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

/tmp/eless >make vcheck
Emacs binary used: /Applications/Emacs.app/Contents/MacOS/Emacs
Loading /tmp/eless/build/setup-eless.el (source)...
Emacs is now refreshing its package database...
Importing package-keyring.gpg...
Importing package-keyring.gpg...done
Contacting host: orgmode.org:443
Failed to download ‘org’ archive.
Failed to download ‘melpa’ archive.
Package refresh done
Installing ‘org-plus-contrib’ ..
Setting ‘package-selected-packages’ temporarily since "emacs -q" would overwrite customizations
Setting ‘package-selected-packages’ temporarily since "emacs -q" would overwrite customizations
Package ‘org-plus-contrib-’ is unavailable
make: *** [vcheck] Error 255

[kaushalmodi]

Thanks. Do you want to hack build/setup-eless.el locally and see if forcing http instead of https helps?

These lines

[kaushalmodi]

Or may be launch Emacs -Q and manually eval the sexps in that setup file responsible for downloading those packages? I don't have a clue why the basic package installation would fail.. That package installation happens every time on Netlify each time https://eless.scripter.co/ deploys.

[kaushalmodi]

.. and here's the package installation on emacs 25.3 on Travis.. so what is so OS specific in that setup file ..

[sshaw]

Found the problem: network-security-level was set to medium. This prompts one for confirmation before connections are made.

Setting this to low here fixed it.

Not sure if there are other solutions.

[kaushalmodi]

Interesting.. so you are prompted each time you install/upgrade a package?

[sshaw]

I use Cask so my installing is done outside emacs. In the cases when I do inside installing it's done via Try and yes, I'm prompted.

[sshaw]

Well, I'm prompted for the host if I haven't been prompted in sometime. Not sure what that is. Seems to be weeks.

[kaushalmodi]

Found the problem: network-security-level was set to medium. This prompts one for confirmation before connections are made.

The default value of this variable (which got introduced in emacs 25.1) is 'medium, and it works fine i.e. I don't get any extra prompt on RHEL 6.6 (or any GNU Linux image on Gitlab Pages/Netlify/Travis). So it's likely that there's something special with macOS?

Setting this to low here fixed it.

Let me create a trial branch where I set that var to low only if the OS is macOS.

[kaushalmodi]

Please try this branch: https://github.com/kaushalmodi/eless/tree/macOS-lower-network-security

[sshaw]

That branch works.

On OS X it may be due to the cert store not containing the CA's cert.

[kaushalmodi]

This too merged into master.