db.js use var slot to save arr[idx]

kaven276 · Sep 28, 2012 · 988bfe8 · 988bfe8
1 parent df383d3
commit 988bfe8
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/lib/db.js b/lib/db.js
@@ -79,11 +79,12 @@ var dbListener = net.createServer({allowHalfOpen : true}, function(c){
     }
 
     logger.db('oracle server(%d:%d) connected, now has %d', c.sid, c.serial, dbListener.connections);
-    if (dbPool[c.pseq]) {
+    var slot = dbPool[c.pseq];
-      dbPool[c.pseq].oraSock = c;
+    if (slot) {
-      dbPool[c.pseq].status = 'free';
+      slot.oraSock = c;
+      slot.status = 'free';
     } else {
-      dbPool[c.pseq] = new Slot(c);
+      slot = dbPool[c.pseq] = new Slot(c);
     }
     freeList.push(c);
 
@@ -92,9 +93,9 @@ var dbListener = net.createServer({allowHalfOpen : true}, function(c){
     c.on('end', function(pos){
       logger.db('oracle server(%d:%d) disconnected, now has %d', c.sid, c.serial, dbListener.connections);
 
-      dbPool[c.pseq].hBytesRead += c.bytesRead;
+      slot.hBytesRead += c.bytesRead;
-      dbPool[c.pseq].hBytesWritten += c.bytesWritten;
+      slot.hBytesWritten += c.bytesWritten;
-      dbPool[c.pseq].status = 'closed';
+      slot.status = 'closed';
 
       pos = find(quitList, c);
       if (~pos) {
@@ -201,6 +202,7 @@ function pushBackToFreelist(oraSock, busyRec){
   logger.db('push back to %d', oraSock.seq);
   oraSock.removeAllListeners('data');
   oraSock.removeAllListeners('timeout');
+
   // mark this busyRec has no oraSock for use, css/fb depend on it to detect timeout clearup
   freeList.unshift(oraSock);
   dbPool[oraSock.pseq].status = 'free';