feat: tracer registration page #18

adityapurwa · 2021-08-08T11:40:23Z

Closes #12

Description

Current Tasks

netlify · 2021-08-08T11:40:29Z

✔️ Deploy Preview for silacak ready!

🔨 Explore the source changes: 906c3c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/silacak/deploys/611151b8390ac100070c4c97

😎 Browse the preview: https://deploy-preview-18--silacak.netlify.app

resir014 · 2021-08-08T14:21:33Z

pages/registration.tsx

@@ -0,0 +1,24 @@
+import Head from "next/head";


registration.tsx -> register.tsx - as per the navbar.

Do you think "Registration" is semantically better as the navigation word is "Registrasi"?

@adityapurwa Hmm, you're right. Feel free to pick whichever you like, but please update the navbar items accordingly.

resir014 · 2021-08-08T14:23:03Z

pages/registration.tsx

+import { ContentBoard } from "~/components/ui/board/content-board/content-board";
+import { FormTitle } from "~/components/ui/form/form-title/form-title";
+import { FormSubtitle } from "~/components/ui/form/form-subtitle/form-subtitle";


Suggested change

import { ContentBoard } from "~/components/ui/board/content-board/content-board";

import { FormTitle } from "~/components/ui/form/form-title/form-title";

import { FormSubtitle } from "~/components/ui/form/form-subtitle/form-subtitle";

import { ContentBoard } from "~/components/ui/board/content-board";

import { FormTitle } from "~/components/ui/form/form-title";

import { FormSubtitle } from "~/components/ui/form/form-subtitle";

Can we compile these exports into each of its root folder? Having the import directory doubled /content-board/content-board doesn't feel like good UX.

Did you mean instead of having ~/components/ui/board/content-board/content-board.tsx, we have ~/components/ui/board/content-board/index.tsx?

@adityapurwa I'm thinking we create an index.ts file and pass all the exports through there, like this:

export * from "./content-board";

I personally avoid having two ways of importing something.

By grouping and exports into an index.ts, we'd now have two ways of importing. Directly to the component file, and using the index groupings. This would introduce inconsistencies.

It will also be problematic with the go-to source feature, as now clicking on the reference will take us to the index file instead of directly to the file of interest.

What do you think about it? Let me know if the decision stands to use export groupings. 🙌

@adityapurwa If you think the content-board folder only contains this one file, I think it's okay to move the content-board.tsx file one folder up (~/components/ui/board/content-board.tsx).

The export grouping I think is only necessary when the folder contains a lot of components. Since export grouping is already used extensively at WBW, and we want to keep our styleguide as close to it as possible, we'll eventually have to use export grouping when we want to group exports of design system components (e.g. those at ~/components/ui/*).

Yes you are correct, I agree we can lift the component file outside of its folder. Even when we adds *.test later, I don't think it'd be too crowded. Let's go with uplifting it then 🚀

Even when we adds *.test later, I don't think it'd be too crowded.

We store tests in a separate __tests__ folder so it wouldn't be a problem regardless. See Jest config for the regex pattern.

resir014 · 2021-08-08T14:27:30Z

@adityapurwa ContentBoard also need to be wrapped inside a wrapping component with a flex-1, since the content wont automatically adjust by the screen height if we don't put in a flex.

Think HomePageContent, but with a background of grey-100.

dreamid27 · 2021-08-08T14:48:13Z

How can i contribute ?

adityapurwa · 2021-08-08T14:53:02Z

How can i contribute ?

Can you edit the PR description?

If you can, the best way to do it is to edit the PR description, add your name next to the checklist item, then create a branch based on tracer-registration. Subsequent PR then would be directed to tracer-registration instead of directly to main.

I will start listing my name next to the checklist item as well so we don't step on each other toes. What do you think @dreamid27 ?

adityapurwa · 2021-08-08T14:54:37Z

@adityapurwa ContentBoard also need to be wrapped inside a wrapping component with a flex-1, since the content wont automatically adjust by the screen height if we don't put in a flex.

Think HomePageContent, but with a background of grey-100.

The content of this form is quite long, are we aiming for a sticky header and footer layout and have the scrollbar inside the middle part?

dreamid27 · 2021-08-08T14:59:38Z

How can i contribute ?

Can you edit the PR description?

If you can, the best way to do it is to edit the PR description, add your name next to the checklist item, then create a branch based on tracer-registration. Subsequent PR then would be directed to tracer-registration instead of directly to main.

Edit this PR? Unfortunately i can't edit the PR..

I will start listing my name next to the checklist item as well so we don't step on each other toes. What do you think @dreamid27 ?

Sure, it will be helping!

adityapurwa · 2021-08-08T15:01:25Z

How can i contribute ?

Can you edit the PR description?
If you can, the best way to do it is to edit the PR description, add your name next to the checklist item, then create a branch based on tracer-registration. Subsequent PR then would be directed to tracer-registration instead of directly to main.

Edit this PR? Unfortunately i can't edit the PR..

I will start listing my name next to the checklist item as well so we don't step on each other toes. What do you think @dreamid27 ?

Sure, it will be helping!

Please comment on which checklist item that you wanted to do, and I will list your name on it.

Thank you @dreamid27 !

dreamid27 · 2021-08-08T15:04:22Z

Form radio button input
Form validation label
Form password input
Button
Info message component

I will take this to do, may I?

adityapurwa · 2021-08-08T15:08:07Z

Form radio button input
Form validation label
Form password input
Button
Info message component

I will take this to do, may I?

Wonderful! Thank you so much for the help. Really appreciated! 🙌
I updated the PR description on parts that you've mentioned.

resir014 · 2021-08-08T15:17:59Z

The content of this form is quite long, are we aiming for a sticky header and footer layout and have the scrollbar inside the middle part?

I don't think that'd be a good idea. Let's stick w/ flex-1 instead.

zainfathoni · 2021-08-09T16:05:32Z

FYI @adityapurwa @dreamid27, you can start using our Form UI components copied from our wargabantuwarga.com project.

adityapurwa · 2021-08-09T16:08:00Z

Heads up ~ I will not be available this week as I will be out of the city. @dreamid27 , if you want to take over this PR, feel free to do so!

resir014 · 2021-08-10T11:36:24Z

@dreamid27, please let us know if you can still work on this. We're running short on time so we need to get this done quickly.

dreamid27 · 2021-08-10T12:55:35Z

@dreamid27, please let us know if you can still work on this. We're running short on time so we need to get this done quickly.

Sure guys!

Maybe the task will done tomorrow

dreamid27 · 2021-08-11T11:17:18Z

You can check the pr here yah :
#42

cc : @zainfathoni @resir014

resir014 · 2021-08-12T14:08:41Z

Superseded by #42.

feat: implement content board component

1abaa45

adityapurwa requested review from resir014 and zainfathoni August 8, 2021 11:40

feat: implement form title

654de28

resir014 suggested changes Aug 8, 2021

View reviewed changes

adityapurwa assigned adityapurwa and dreamid27 Aug 8, 2021

adityapurwa and others added 3 commits August 8, 2021 22:41

feat: implement base form text input

71c348b

Merge branch 'main' into tracer-registration

fe37e27

Merge branch 'main' into tracer-registration

906c3c5

adityapurwa marked this pull request as ready for review August 9, 2021 16:10

dreamid27 mentioned this pull request Aug 11, 2021

feat: tracer registration page #42

Merged

10 tasks

resir014 closed this Aug 12, 2021

zainfathoni deleted the tracer-registration branch August 13, 2021 05:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: tracer registration page #18

feat: tracer registration page #18

adityapurwa commented Aug 8, 2021 •

edited

Loading

netlify bot commented Aug 8, 2021 •

edited

Loading

resir014 Aug 8, 2021

adityapurwa Aug 8, 2021

resir014 Aug 8, 2021

resir014 Aug 8, 2021

adityapurwa Aug 8, 2021

resir014 Aug 8, 2021

adityapurwa Aug 8, 2021

resir014 Aug 8, 2021

adityapurwa Aug 8, 2021

resir014 Aug 8, 2021 •

edited

Loading

resir014 commented Aug 8, 2021

dreamid27 commented Aug 8, 2021

adityapurwa commented Aug 8, 2021

adityapurwa commented Aug 8, 2021

dreamid27 commented Aug 8, 2021 •

edited

Loading

adityapurwa commented Aug 8, 2021

dreamid27 commented Aug 8, 2021

adityapurwa commented Aug 8, 2021

resir014 commented Aug 8, 2021

zainfathoni commented Aug 9, 2021

adityapurwa commented Aug 9, 2021

resir014 commented Aug 10, 2021

dreamid27 commented Aug 10, 2021

dreamid27 commented Aug 11, 2021 •

edited

Loading

resir014 commented Aug 12, 2021

feat: tracer registration page #18

feat: tracer registration page #18

Conversation

adityapurwa commented Aug 8, 2021 • edited Loading

Description

Current Tasks

netlify bot commented Aug 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

resir014 Aug 8, 2021 • edited Loading

Choose a reason for hiding this comment

resir014 commented Aug 8, 2021

dreamid27 commented Aug 8, 2021

adityapurwa commented Aug 8, 2021

adityapurwa commented Aug 8, 2021

dreamid27 commented Aug 8, 2021 • edited Loading

adityapurwa commented Aug 8, 2021

dreamid27 commented Aug 8, 2021

adityapurwa commented Aug 8, 2021

resir014 commented Aug 8, 2021

zainfathoni commented Aug 9, 2021

adityapurwa commented Aug 9, 2021

resir014 commented Aug 10, 2021

dreamid27 commented Aug 10, 2021

dreamid27 commented Aug 11, 2021 • edited Loading

resir014 commented Aug 12, 2021

adityapurwa commented Aug 8, 2021 •

edited

Loading

netlify bot commented Aug 8, 2021 •

edited

Loading

resir014 Aug 8, 2021 •

edited

Loading

dreamid27 commented Aug 8, 2021 •

edited

Loading

dreamid27 commented Aug 11, 2021 •

edited

Loading