Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

feat: tracer registration page #42

Merged
merged 18 commits into from
Aug 12, 2021

Conversation

dreamid27
Copy link
Contributor

@dreamid27 dreamid27 commented Aug 11, 2021

Closes #12

Description

Continue from this pr #18

localhost_3000_registration

Current Tasks

@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ Deploy Preview for silacak ready!

🔨 Explore the source changes: 978ea91

🔍 Inspect the deploy log: https://app.netlify.com/sites/silacak/deploys/61152d2baad9840008381b5e

😎 Browse the preview: https://deploy-preview-42--silacak.netlify.app

@dreamid27 dreamid27 changed the title Dreamid27/registration feat: registration Aug 11, 2021
@dreamid27
Copy link
Contributor Author

@resir014 @zainfathoni please help to review yah

@dreamid27 dreamid27 mentioned this pull request Aug 11, 2021
10 tasks
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreamid27 @adityapurwa Some changes are necessary, please look into them.

components/registration/registration-form.tsx Outdated Show resolved Hide resolved
components/registration/registration-form.tsx Outdated Show resolved Hide resolved
components/registration/registration-form.tsx Outdated Show resolved Hide resolved
components/registration/registration-form.tsx Outdated Show resolved Hide resolved
components/registration/registration-form.tsx Outdated Show resolved Hide resolved
components/registration/registration-info-message.tsx Outdated Show resolved Hide resolved
@resir014
Copy link
Member

Hi @dreamid27, both me and @zainfathoni are going to start pushing into this PR, since we need to urgently get this done and merged as soon as possible, so you don't need to push anymore. We're going to take care of it.

@resir014 resir014 dismissed their stale review August 12, 2021 14:04

The requested changes have been implemented properly.

@resir014 resir014 changed the title feat: registration feat: registration page Aug 12, 2021
@resir014 resir014 changed the title feat: registration page feat: tracer registration page Aug 12, 2021
@resir014 resir014 added the automerge To be automatically merged once all checks are passed label Aug 12, 2021
Copy link
Member

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@kodiakhq kodiakhq bot merged commit b037f1e into kawalcovid19:main Aug 12, 2021
@dreamid27 dreamid27 deleted the dreamid27/registration branch August 12, 2021 15:15
@dreamid27
Copy link
Contributor Author

@zainfathoni @resir014 yeah sure, thank you for care about it...

Sorry for the deadline yah...

@zainfathoni
Copy link
Member

@zainfathoni @resir014 yeah, sure, thank you for care about it...

Sorry for the deadline, yah...

It's okay. You can help with the other issues, we still have a lot to do, and we're splitting them into more granular issues. 😉

@zainfathoni
Copy link
Member

@all-contributors please add @adityapurwa @dreamid27 for code.

@allcontributors
Copy link
Contributor

@zainfathoni

I've put up a pull request to add @adityapurwa! 🎉

@zainfathoni
Copy link
Member

@all-contributors please add @dreamid27 for code.

@allcontributors
Copy link
Contributor

@zainfathoni

I've put up a pull request to add @dreamid27! 🎉

@zainfathoni
Copy link
Member

@all-contributors please add @resir014 for test

@allcontributors
Copy link
Contributor

@zainfathoni

I've put up a pull request to add @resir014! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge To be automatically merged once all checks are passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracer Registration Form
4 participants