-
Notifications
You must be signed in to change notification settings - Fork 24
feat: tracer registration page #42
feat: tracer registration page #42
Conversation
✔️ Deploy Preview for silacak ready! 🔨 Explore the source changes: 978ea91 🔍 Inspect the deploy log: https://app.netlify.com/sites/silacak/deploys/61152d2baad9840008381b5e 😎 Browse the preview: https://deploy-preview-42--silacak.netlify.app |
@resir014 @zainfathoni please help to review yah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreamid27 @adityapurwa Some changes are necessary, please look into them.
Hi @dreamid27, both me and @zainfathoni are going to start pushing into this PR, since we need to urgently get this done and merged as soon as possible, so you don't need to push anymore. We're going to take care of it. |
The requested changes have been implemented properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
@zainfathoni @resir014 yeah sure, thank you for care about it... Sorry for the deadline yah... |
It's okay. You can help with the other issues, we still have a lot to do, and we're splitting them into more granular issues. 😉 |
@all-contributors please add @adityapurwa @dreamid27 for code. |
I've put up a pull request to add @adityapurwa! 🎉 |
@all-contributors please add @dreamid27 for code. |
I've put up a pull request to add @dreamid27! 🎉 |
@all-contributors please add @resir014 for test |
I've put up a pull request to add @resir014! 🎉 |
Closes #12
Description
Continue from this pr #18
Current Tasks