-
Notifications
You must be signed in to change notification settings - Fork 24
feat(page): check activation account #41
feat(page): check activation account #41
Conversation
✔️ Deploy Preview for silacak ready! 🔨 Explore the source changes: b6720e5 🔍 Inspect the deploy log: https://app.netlify.com/sites/silacak/deploys/612625a0aab996000791a723 😎 Browse the preview: https://deploy-preview-41--silacak.netlify.app |
Co-authored-by: Resi Respati <resir014@gmail.com>
I think it's about time we start implementing a form library before it's too late. What do you think, @zainfathoni? For ease of use, we can use one of these two form libraries: |
also, I want to ask, |
Agreed, let's use |
Please just use You can read more about it in our principles. |
@asaadam @zainfathoni If we still want to add hooks to make fetching easier, we can also use swr which is a more lightweight version of react-query. But if it's possible, please still use regular |
That's a good idea. I think |
…com/asaadam/silacak into feat/pages/check-activation-account
hello mas @zainfathoni and mas @resir014 should I declare this orange color on |
What do you think, @resir014? In my opinion, we should simply use the existing color palette to reduce the cognitive load of picking which colors to use. And since we don't need to achieve a pixel-perfect standard for this MBP iteration, I think a little bit of color deviation should be tolerated as well. |
hello, again mas @zainfathoni and mas @resir014 could you check my implementation on SWR and react-hook-form? I think it gonna be a lot of corrections 😅 because it's my first time using that lib. |
also, I got cors response, should I create reverse-proxy? |
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 58.24% 55.52% -2.72%
==========================================
Files 61 52 -9
Lines 455 416 -39
Branches 172 172
==========================================
- Hits 265 231 -34
+ Misses 184 179 -5
Partials 6 6
Continue to review full report at Codecov.
|
as per @ramarahmanda says, I remove SWR implementation. |
Please test your new files so that it passes the codecov CI checks, @asaadam. Thanks! 🙏 |
…com/asaadam/silacak into feat/pages/check-activation-account
done yak mas, please check it again |
@all-contributors please add @asaadam for testing |
I've put up a pull request to add @asaadam! 🎉 |
Closes #28
Description
Current Tasks
Todo: