-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace toMatchInlineSnapshot with meaningful assertions #728
Conversation
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: 96360d6 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/6119a074ade2c000077cc766 😎 Browse the preview: https://deploy-preview-728--wargabantuwarga.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #728 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 128 128
Lines 1404 1404
Branches 464 464
=======================================
Hits 1182 1182
Misses 215 215
Partials 7 7 Continue to review full report at Codecov.
|
…/__tests__/* files
7e51141
to
88ce912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on it, @adibfirman. 🙏
I have some change requests, though. 😁
@adibfirman could you create a task list like on the issue? so we can track all the changes
|
@rubiagatra updated mas 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few more minor changes. 😁 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thanks for working on it, @adibfirman! 🙏
You've unblocked some stale issues & PRs, including #722. 🚀
@all-contributors please add @adibfirman for test |
I've put up a pull request to add @adibfirman! 🎉 |
Closes #697
Description
Basically, assertion
toMatchInlineSnapshot
have an unnecessary snapshot to each PR's (according to the issue) so we just to remove that and replace it with something meaningful assertionsCurrent Tasks
Replacing
toMatchInlineSnapshot
to these files.(*) it means that the assertion it's simple and not necessary to remove it.