workflows: pin cilium-cli version to v0.8.6

[ upstream commit 2202dae ]

In cilium#16892, we switched from pinning CLI version in workflows to using
the latest stable version automatically. This can cause issues if a new
release does not play nice with the set of environments tested by the
workflows on `cilium/cilium`.

We are reverting to pinning CLI version so as to have better control
over the test environment, and avoid new CLI releases negatively
impacting `cilium/cilium` workflows immediately upon release.

With the CLI version pinned, any issues with the new version will be
detected in the PR bumping the pinned version, allowing us to fix them
prior to merging.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>

.github/workflows/conformance-kind.yaml

@@ -22,8 +22,7 @@ concurrency:
 env:
   kind_version: v0.11.1
   kind_config: .github/kind-config.yaml
-  cilium_install_defaults: |
-
+  cilium_cli_version: v0.8.6
 
 jobs:
   installation-and-connectivity:
@@ -52,8 +51,7 @@ jobs:
 
       - name: Install Cilium CLI
         run: |
-          export CILUM_CLI_VERSION=$(curl -s https://raw.githubusercontent.com/cilium/cilium-cli/master/stable.txt)
-          curl -sSL --remote-name-all https://github.com/cilium/cilium-cli/releases/download/$CILUM_CLI_VERSION/cilium-linux-amd64.tar.gz{,.sha256sum}
+          curl -sSL --remote-name-all https://github.com/cilium/cilium-cli/releases/download/${{ env.cilium_cli_version }}/cilium-linux-amd64.tar.gz{,.sha256sum}
           sha256sum --check cilium-linux-amd64.tar.gz.sha256sum
           sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/local/bin
           rm cilium-linux-amd64.tar.gz{,.sha256sum}