.github/workflows: use latest stable cilium-cli release #16892
Merged
+36
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/CI
rolinh
reviewed
Jul 15, 2021
tklauser
added
the
dont-merge/preview-only
tklauser
force-pushed
the
pr/tklauser/bump-cilium-cli-0.8.5
branch
from
f2706c1
to
97f47ad
Compare
tklauser
changed the title
rolinh
approved these changes
Jul 16, 2021
tklauser
force-pushed
the
pr/tklauser/bump-cilium-cli-0.8.5
branch
from
97f47ad
to
88f8aef
Compare
Use the stable.txt file in the cilium-cli repo to always fetch the latest stable release. Suggested-by: Robin Hahling <robin.hahling@gw-computing.net> Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
All conformance workflows passed:
Removing temporary commit and marking as ready to review. |
tklauser
removed
the
dont-merge/preview-only
tklauser
force-pushed
the
pr/tklauser/bump-cilium-cli-0.8.5
branch
from
88f8aef
to
5036435
Compare
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.4
nbusseneau
added a commit
that referenced
this pull request
Aug 11, 2021
In #16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on `cilium/cilium`. We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting `cilium/cilium` workflows immediately upon release. With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
ti-mo
pushed a commit
that referenced
this pull request
Aug 13, 2021
In #16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on `cilium/cilium`. We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting `cilium/cilium` workflows immediately upon release. With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.4
kaworu
pushed a commit
to kaworu/cilium
that referenced
this pull request
Sep 27, 2021
[ upstream commit 2202dae ] In cilium#16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on `cilium/cilium`. We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting `cilium/cilium` workflows immediately upon release. With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
jibi
pushed a commit
that referenced
this pull request
Sep 29, 2021
[ upstream commit 2202dae ] In #16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on `cilium/cilium`. We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting `cilium/cilium` workflows immediately upon release. With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
krishgobinath
pushed a commit
to krishgobinath/cilium
that referenced
this pull request
Oct 20, 2021
In cilium#16892, we switched from pinning CLI version in workflows to using the latest stable version automatically. This can cause issues if a new release does not play nice with the set of environments tested by the workflows on `cilium/cilium`. We are reverting to pinning CLI version so as to have better control over the test environment, and avoid new CLI releases negatively impacting `cilium/cilium` workflows immediately upon release. With the CLI version pinned, any issues with the new version will be detected in the PR bumping the pinned version, allowing us to fix them prior to merging. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
stable.txtfile in the cilium-cli repo to always fetch thelatest stable release.