Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify subcommand should use ssm:GetParameters to simulate actual ECS' behavior #677

Closed
aereal opened this issue Mar 19, 2024 · 1 comment

Comments

@aereal
Copy link
Contributor

aereal commented Mar 19, 2024

Expected behavior

ecspresso verify with the IAM role that allowed only ssm:GetParameters action should successfully get the parameter(s) from AWS Systems Manager Parameters Store.

Actual behavior

It fails due to lack of the permission to call ssm:GetParameter (the singular one, not the plural one).

refs.

_, err := v.ssm.GetParameter(ctx, &ssm.GetParameterInput{

Proposed solution

It calls ssm:GetParameters instead of ssm:GetParameter.

That change also introduce the chance to reduce the API calls.

@fujiwara
Copy link
Contributor

@aereal Thank you! v2.3.3 released!
https://github.com/kayac/ecspresso/releases/tag/v2.3.3

I added #681 for backward compatibility. When GetParameters API fails with "access denied", fallback to GetParameter API with warning logs. This fallback will be removed v2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants