Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use GetParameters instead of GetParameter to simulate actual ECS' behavior #678

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

aereal
Copy link
Contributor

@aereal aereal commented Mar 19, 2024

This PR may solve the problem reported in #677.

Now we get the chance to reduce the API calls but this PR replaces the ssm:GetParameter call with ssm:GetParameters.

@fujiwara
Copy link
Contributor

@aereal Thank you!!

I've confirmed to the Fargate agent calls the "GetParameters" API by CloudTrail logs.

@fujiwara fujiwara merged commit 7143a5f into kayac:v2 Mar 19, 2024
2 checks passed
fujiwara added a commit that referenced this pull request Mar 29, 2024
refs #678
To backward compatibility, fallbacking to ssm.GetParameter API.

This will be removed at ecspresso 2.4.
fujiwara added a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants