Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Rollup operation in highcharts #14

Merged
merged 4 commits into from
Aug 16, 2016
Merged

Fixes for Rollup operation in highcharts #14

merged 4 commits into from
Aug 16, 2016

Conversation

twheys
Copy link
Contributor

@twheys twheys commented Aug 16, 2016

Fixed for Highcharts

Line Charts

  • Fixed the yAxis for metrics

Bar Charts

  • Fixed the yAxis (should always be 0)
  • Fixed the labels to correctly replace None and NaN values with 'Totals'

@coveralls
Copy link

coveralls commented Aug 16, 2016 •
edited

Coverage Status

Coverage increased (+0.002%) to 95.448% when pulling c8c7b1e on rollup_fix into 77c9df1 on master.

@twheys
Renamed Rollup to Totals, changed constructor to accept *args instead…
512c253 
… of a list, removed imports for references and operations from slicer.__init__ so these must be imported from their respective packages, updated docs
@coveralls
Copy link

coveralls commented Aug 16, 2016 •
edited

Coverage Status

Coverage increased (+0.002%) to 95.448% when pulling 512c253 on rollup_fix into 77c9df1 on master.

@twheys twheys merged commit 51d3351 into master Aug 16, 2016
@twheys twheys deleted the rollup_fix branch August 23, 2016 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twheys @coveralls