SEOD-1326. Bump fireant to pandas version 2 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump fireant version to 8.0.0 - Drop support for Python3.7 as pandas v2 does not support it - Add Python3.9 support - Use the newest `pandas` (2.0.3 in requirements) and add the minimum version 2.0.0 of `pandas` to pyproject.toml - Use the newest `vertica-python` (1.3.4 in requirements) and add the minimum version 1.0.0 of `vertica-python` to pyproject.toml - Use the newest `snowflake-connector-python` (3.0.4 in requirements) and add the minimum version 3.0.0 of `snowflake-connector-python` to pyproject.toml - Use the newest `coverage` (7.3.0 in requirements) and add the minimum version 7.3.0 of `coverage` to pyproject.toml - Use the newest `watchdog` (3.0.0 in requirements) and add the minimum version 3.0.0 of `watchdiog` to pyproject.toml - Remove `python-dateutil` from dependencies as it is part of other libraries' dependencies - Bump `psycopg-binary==2.9.6` though it seems not needed for the tests - Bump `pymssql==2.2.7` though it seems not needed for the tests - Bump `Cython==3.0.0` though it seems not needed for the tests - Get rid of `SyntaxWarning: "is" with a literal. Did you mean "=="?` - Get rid of `DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working` - Replace `Dataframe.append` to `pd.concat` because `append` does not exist since pandas v2 - Add `group_keys=False` to `DataFrame.groupby()` method because it is no longer ignored since pandas v1.5 - Fix `_apply_share` method for `Share`s with the new libraries. - Rename `TestDatabase` to `MockDatabase` since it is used only for mocking. This is beneficial also because Python testing method will not delve into it to find methods to run - Rename `test_connect` and `test_fetch` to `mock_connect` and `mock_fetch` as these are mocks. This is beneficial also because Python testing method will not delve into it to find methods to run - Rename `TestMySQLDatabase` to `MockMySQLDatabase` for the same reason - When concatenating `DataFrames`, use `.tail(1)` instead of `.iloc[-1]` as it includes indexes - Use static CSVs to get the expected `DataFrames` in tests instead of applying methods of `fireant` to a `DataFrame` to get those expected `DataFrames` - Replace `np.float` to `float` since it was deprecated - Get rid of `None` and `[]` as `ascending` parameters for `Pandas` class - Replace `.iteritems()` with `.items()` as the former method was deprecated
|
Bump fireant version to 8.0.0 instead of 7.10.0 because Python3.7 support was dropped and pandas v2 has been introduced. This introduces breaking changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas(2.0.3 in requirements) and add the minimum version 2.0.0 ofpandasto pyproject.tomlvertica-python(1.3.4 in requirements) and add the minimum version 1.0.0 ofvertica-pythonto pyproject.tomlsnowflake-connector-python(3.0.4 in requirements) and add the minimum version 3.0.0 ofsnowflake-connector-pythonto pyproject.tomlcoverage(7.3.0 in requirements) and add the minimum version 7.3.0 ofcoverageto pyproject.tomlwatchdog(3.0.0 in requirements) and add the minimum version 3.0.0 ofwatchdiogto pyproject.tomlpython-dateutilfrom dependencies as it is part of other libraries' dependenciespsycopg-binary==2.9.6though it seems not needed for the testspymssql==2.2.7though it seems not needed for the testsCython==3.0.0though it seems not needed for the testsSyntaxWarning: "is" with a literal. Did you mean "=="?DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop workingDataframe.appendtopd.concatbecauseappenddoes not exist since pandas v2group_keys=FalsetoDataFrame.groupby()method because it is no longer ignored since pandas v1.5_apply_sharemethod forShares with the new libraries.TestDatabasetoMockDatabasesince it is used only for mocking. This is beneficial also because Python testing method will not delve into it to find methods to runtest_connectandtest_fetchtomock_connectandmock_fetchas these are mocks. This is beneficial also because Python testing method will not delve into it to find methods to runTestMySQLDatabasetoMockMySQLDatabasefor the same reasonDataFrames, use.tail(1)instead of.iloc[-1]as it includes indexesDataFramesin tests instead of applying methods offireantto aDataFrameto get those expectedDataFramesnp.floattofloatsince it was deprecatedNoneand[]asascendingparameters forPandasclass.iteritems()with.items()as the former method was deprecated