Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing from original #1

Merged
merged 1,927 commits into from
Aug 26, 2019
Merged

Syncing from original #1

merged 1,927 commits into from
Aug 26, 2019

Conversation

kaypeter87
Copy link
Owner

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

michelsonhns and others added 30 commits August 14, 2019 16:06
* Bulma

* fixed title and localeTitle syntax

* correctly lowercase folder name and added index.md
* fix: title and translation

* Update index.md
…5966)

* Squashed the removal of the before test section

* fix: changed blockquote triple backtick syntax

* fix: removed recursion explanation

* fix: changed meta title and thru to through

* fix: capitalize "after" in several strings
* improvement of 'Basic Math' documentation

* fix: corrected code block formatting
Added the basic html tutorial in portuguese as well as the explanation for each of the tags contained in the basic structure.
The programming language expression was translated to portuguese to a word similar to 'idiom'.
… english one (#26961)

* Fix translation of game Inside.

https://store.steampowered.com/app/304430/INSIDE/?l=portuguese

* Fix wrong title of Cuphead

* Fix portuguese local title to Unity

* Update formatting of the Interface section to be more clear and match the english one
Improved some sentences to make sense in portuguese. Also corrected some words that doesn't need to be translated.
Added missing translations, improved some wording and removed extraneous whitespace.
* Remove whitespaces and fix indentation

* Other fixes to match english version
lauren-rutledge and others added 29 commits August 20, 2019 14:36
* Minor grammar fix
Added Example of a Diamond Printing code
* [Update] Added guide for unordered_map

* fix: removed unsecure links
* Typescript -> TypeScript (spanish)

* Update index.md
* update translation greedy-algorithms

* updated translation after review
…ies. (#36586)

First on constant variable issue:

This will not compile:

[Plugin(MyPluginName)] // Won't compile because MyPluginName isn't const
[Plugin(MyConstPluginName)] // OK
[Plugin("My Cool Plugin")] // OK

In order to access properties on the static class, it must specify the name of the class before the properties name as proposed on this change:

[Plugin(Variables.MyPluginName)] // Won't compile because MyPluginName isn't const
[Plugin(Variables.MyConstPluginName)] // OK
[Plugin("My Cool Plugin")] // OK

Second on access on attribute properties:

In order to access plugin.Name on this code:

var type = typeof(MyPlugin); // Returns a Type object representing our MyPlugin class
	var attributes = System.Attribute.GetCustomAttributes(type); // Returns an Attribute[]

	foreach (var a in attributes)
	{
		if (a is PluginAttribute plugin)
			Console.WriteLine($"Plugin Name: {plugin.Name}");
	}

You need to cast if first to the right class, then access the properties, as the above code will generate a compile-time error:

var type = typeof(PluginAttribute); // Returns a Type object representing our PluginAttribute class
	var attributes = System.Attribute.GetCustomAttributes(type); // Returns an Attribute[]

	foreach (var a in attributes)
	{
		if (a is PluginAttribute)
                    {
                        PluginAttribute plug = (PluginAttribute)a; //Cast it first to PluginAttribute class before you can access all accessible properties
                        Console.WriteLine($"Plugin Name: {plug.Name}");
                    }
	}
Added a lot more of information and code examples
* Added colors from the style guide to :root so they're available globally. Also switched out hex codes for named variables in .dark-palette and .light-palette wherever possible.

* feat: add success and danger colors to root
* Track if donation modal has opened in a session

* Fix prettier problem

* Create separate action that switches donationRequested
Distintas mejoras de traducción. Sobretodo el continuo uso de "Cuerdas" en vez de "Cadena" para el término de String.
* Guide to the Data Visualization with D3 Work with Data in D3

* Guide to data visualization with d3 work with data in d3

* Delete index.md
* Update index.md

I think it can be interesting to propose a solution using RegExp.

* fix: wrapped code in code fences
* fix/donate-progress-bar-color

* fix/colors
For better translation, following the context of the paragraph, the lines 25 and 52 should be changed for this version,
* the Wikipedia link now points to the Russian Wikipedia page on DRY
Removed twice repeated text.
* fix/heatmap-colors

* fix/simplify-variables

* fix/if-statements+typo
@kaypeter87 kaypeter87 merged commit 2cfc7e4 into kaypeter87:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment