Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Automake to run tests, and other test improvements #44

Merged
merged 11 commits into from May 15, 2024

Conversation

rhansen
Copy link
Contributor

@rhansen rhansen commented Apr 27, 2024

No description provided.

The name `data` implies that they are somehow incorporated (or required by) the
`pgpdump` binary.
The shell script is perfectly adequate, and doesn't require additional
dependencies.
This will make it possible for a future commit to use the script as an
Automake test driver.
The extension is unnecessary, and dropping it makes it easier to use a
different scripting language in the future if desired.
This is a step to running the tests from Automake via `make check`.
This will be used by the Automake TAP harness in a future commit.
Now `make check` and `make distcheck` run the unit tests.
@kazu-yamamoto kazu-yamamoto self-requested a review May 15, 2024 01:36
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit c0a8445 into kazu-yamamoto:main May 15, 2024
@kazu-yamamoto
Copy link
Owner

Merged.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants