Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream support using StreamIterator. #23

Closed
wants to merge 5 commits into from

Conversation

sun-jiao
Copy link

@sun-jiao sun-jiao commented May 11, 2023

I replaced all Iterator with StreamIterator for code reusing. This may be a breaking change because the methods were changed to asynchronous.

I've also considered keeping both sync (Iterator) and async (StreamIterator) versions, but they are very similar, maintaining two versions at the same time may be exhausting or cause unnecessary risks. .

@sun-jiao sun-jiao marked this pull request as draft May 11, 2023 23:31
@sun-jiao sun-jiao marked this pull request as ready for review May 12, 2023 00:24
@sun-jiao sun-jiao closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant