Add KmlReader and fromStream.
#24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f4542cc Author: Sun Jiao <P.ozzy@outlook.com> Date: Fri May 12 08:24:02 2023 +0800 fix tests and add read stream to README commit e242adb Author: Sun Jiao <P.ozzy@outlook.com> Date: Thu May 11 23:13:00 2023 +0800 add `Stream_converter.dart` and change `Iterator` to `StreamIterator` all tests passed commit 233e9c6 Author: Sun Jiao <P.ozzy@outlook.com> Date: Thu May 11 22:27:22 2023 +0800 Add fromStream
Squashed commit of the following: commit 4e9f91c Author: Sun Jiao <P.ozzy@outlook.com> Date: Fri May 12 15:46:59 2023 +0800 add test cases commit 9bd60cd Author: Sun Jiao <P.ozzy@outlook.com> Date: Fri May 12 15:41:43 2023 +0800 add <gx:Track> support commit 25b7a4c Author: Sun Jiao <P.ozzy@outlook.com> Date: Fri May 12 14:47:53 2023 +0800 add <gx:Track> support
|
Closed cause they are tooo different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use main branch to keep same commit history between 2 repositories.
#22
Hi. I made a
KmlReaderbased on your library for my personal project. And I wish it could be added to the original library.Of course. I know this is a gpx library. If you don't think my pr fits your library, please fell free to close it.
#23
I replaced all
IteratorwithStreamIteratorfor code reusing. This may be a breaking change because the methods were changed to asynchronous.I've also considered keeping both sync (
Iterator) and async (StreamIterator) versions, but they are very similar, maintaining two versions at the same time may be exhausting or cause unnecessary risks. .