New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port osgOcean to OSG 3.4.x - use osg/Version to keep backwards compatibility #52
Conversation
Hi @kbale - could you please merge this PR? Or tell me what you'd like changed. |
Hi @fcami I have quickly tried your changes on Linux with the So for me, this PR is fine. But, in the code, I would prefer: #if OSG_VERSION_LESS_THAN(3,2,2) instead of #if OSG_VERSION_GREATER_THAN(3,2,1) Because if the API change in the future, we would have to nest the preprocessor macros, which would be less readable. |
Hi @romainreignier & @kbale |
OSG API changes: fix versions
PR updated & I think I got the versions right this time. |
Ok, I prefer that version. I saw that you change the version number according to the change. I did not check these but I assume you checked them. |
I checked them and they should be right. Note "should": time permitting I would have built those versions and double-checked (and I didn't). |
Successfully compiled on MSVC 2015 using OSG 3.4.0 binaries. Would vote for a merge. |
@whatnick Did you try the |
@whatnick @romainreignier maybe you're hitting a shader issue: #53 ? Everything I get underwater seems to be uniform (white on my graphical stack). |
Hence issues are due to shader limitations on embedded GPU on Intel.
…On Feb 7, 2018 18:47, "Romain Reignier" ***@***.***> wrote:
@whatnick <https://github.com/whatnick> Thanks for taking the time to
test so it seems OK.
@kbale <https://github.com/kbale> This PR seems great and should be
merged.
@fcami <https://github.com/fcami> Yes, it may be related. I think that on
OSG 3.2, I only had this issue on Intel GPU, using the second GPU on my
laptop, NVidia 750M, there were no issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#52 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAd_hNGJU0uxPQRBRofHu9Sw1t1u_va_ks5tSVwEgaJpZM4QMjED>
.
|
Where are we on this? :) OpenMW is interested in including this and we're based on osg3.4 |
Hi @fcami My apologies for not merging this sooner, I've recently had a baby and I really haven't had time to keep up with any changes to osgOcean, it's been some time since I worked on this project. None the less, it's in now, thank you for your contribution. |
@kbale Congratulations! Welcome to the no-sleep club. :P |
hi @kbale, no worries, thanks for merging! |
Very useful pull request for OSG migration. Thanks. |
Thanks @lucasamparo , that kind of feedback is gold to me. |
These changes make osgOcean work against OpenSceneGraph 3.4.1 and should preserve backwards compatibility.