Handle zero Eth Type #445
Merged
Handle zero Eth Type #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 Ethernet - LLC. This is what Wireshark does.
|
Looks like I broke a LLC test. I'll look into if that was a valid test case originally. |
added 2 commits
January 31, 2019 14:56
…type == 0 is valid in ISL.
|
Good work. Thanks! |
obormot
pushed a commit
that referenced
this pull request
Apr 5, 2020
* Check for ethtype == 0 and handle as Ethernet II instead of IEEE 802.3 Ethernet - LLC. This is what Wireshark does. * Move check for ethtype == 0 to after check for ISL protocol since ethtype == 0 is valid in ISL. * Add unit test for zero ethtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #442.
Proposed solution:
Check for
ethtype == 0and handle asEthernet IIinstead ofIEEE 802.3 Ethernet - LLC. This is what Wireshark does.