behave better when service down [SCT-1075]

kbase · Jun 13, 2018 · b06ac6e · b06ac6e
1 parent b76c7c5
commit b06ac6e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/bower.json b/bower.json
@@ -37,7 +37,7 @@
       "kbase-knockout-extensions-es6": "0.1.4",
       "kbase-common-ts": "0.18.0",
       "kbase-common-js": "2.16.1",
-      "kbase-common-es6": "0.5.1",
+      "kbase-common-es6": "0.5.2",
       "kbase-sdk-clients-js": "0.5.1",
       "kbase-service-clients-js": "3.3.5",
       "kbase-ui-widget": "1.3.0",

diff --git a/src/client/modules/lib/kbaseServiceManager.js b/src/client/modules/lib/kbaseServiceManager.js
@@ -49,8 +49,8 @@ define([
                         throw new Error(errorMessage);
                     } else {
                         console.error(errorMessage);
+                        return null;
                     }
-
                 });
         }
 
@@ -70,6 +70,7 @@ define([
                         throw new Error(errorMessage);
                     } else {
                         console.error(errorMessage);
+                        return null;
                     }
                 });
         }
@@ -89,11 +90,18 @@ define([
                                 throw new Error(errorMessage);
                             } else {
                                 console.error(errorMessage);
+                                return null;
                             }
                         }
                     }).then((result) => {
                         let version;
-                        if (serviceConfig.version.propertyPath) {
+                        if (result === null) {
+                            if (!this.throwErrors) {
+                                return null;
+                            } else {
+                                throw new Error('Invalid semver check result: ' + result);
+                            }
+                        } else if (serviceConfig.version.propertyPath) {
                             version = props.getProp(result, serviceConfig.version.propertyPath);
                         } else {
                             version = result;