Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-1050 some frontend test refactoring #1177

Merged
merged 14 commits into from
Oct 25, 2017
Merged

Conversation

briehl
Copy link
Member

@briehl briehl commented Oct 4, 2017

Tests should now generate code coverage (still pending some checking to see if that functions properly. Even with more complete tests, it seems like there's some false negatives).

There's also a test utility module that helps manage tokens.

(doing these later)
TODO:
Add util for creating a narrative
Add util for uploading test data
Add util for deleting workspaces (maybe. might also just wait until the Mini-KBase stuff is done and operate against that environment)

@briehl
Copy link
Member Author

briehl commented Oct 23, 2017

There's still some TODOs that'll make life easier, but I think we should get this merged, if only to expose coverage and Auth2 token use.

@eapearson @sychan mind taking a look here?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 03ee1a7 on briehl:test-refactor into ** on kbase:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9373496 on briehl:test-refactor into ** on kbase:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e68a7ba on briehl:test-refactor into ** on kbase:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d187ed5 on briehl:test-refactor into ** on kbase:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ceca95d on briehl:test-refactor into ** on kbase:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4f896c5 on briehl:test-refactor into ** on kbase:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling dc0ae3e on briehl:test-refactor into ** on kbase:develop**.

@sychan sychan merged commit 5f4983b into kbase:develop Oct 25, 2017
@briehl briehl deleted the test-refactor branch May 8, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants