TASK-1128 Introduces a dropdown that populates itself from the staging area #1191
Conversation
|
Needs tests now. |
| @@ -105,62 +105,59 @@ define([ | |||
| */ | |||
| function updateConfig() { | |||
| return new Promise.try(function (resolve, reject) { | |||
There was a problem hiding this comment.
this should be just
new Promise(function (resolve, reject) {...
also if anything throws in here (assertConfig()?) it will not cause the promise to reject, but rather the constructor will fail and throw.
| }); | ||
| } else { | ||
| if (window.kbconfig) { | ||
| return window.kbconfig; |
There was a problem hiding this comment.
also, this won't resolve with the config -- it would have if this was original simply Promise.try()
| console.log('Config: processing local data configuration.'); | ||
| config.publicCategories = dataCategories[config.environment].publicData; | ||
| config.exampleData = dataCategories[config.environment].exampleData; | ||
| return Promise.try(function () { |
There was a problem hiding this comment.
and these Promse.trys are not necessary since they simply return a value -- just returning the value will continue the promise chain.
| return Promise.try(function() { | ||
| var selectedItem = getControlValue(), | ||
| validationConstraints = { | ||
| min_length: 1, |
There was a problem hiding this comment.
shouldn't the validation constraints be driven from the spec or sdk.js? trawling back through memory of how this is used elsewhere.
There was a problem hiding this comment.
also in theory wouldn't the validation go against the data source? I mean, in actual usage the value is derived from a dropdown derived from the data source, but as far as the control knows, at some future time this may not be true. That is a problem in general for this control, though, since all files will eventually disappear and thus every instance of this parameter will become invalid. Hmm..
There was a problem hiding this comment.
Yes, but these aren't expected to have string constraints as it's a new parameter type, and I'm coding around some still needed changes to the narrative method store. Those are just there as default values, though sdk.js should cough up the defaults itself, instead of the input widget. I'll change that.
| @@ -0,0 +1,70 @@ | |||
| /*global define*/ | |||
There was a problem hiding this comment.
wow, parameter control specs!!
There was a problem hiding this comment.
Not perfect, but it's a start! :)
I'm trying to not introduce any new code without a few tests. Hopefully, it'll become a trend...
|
Ok, adjusted stuff with your comments, and fixed tests so they get actually get skipped when no auth is present. |
MERGE #1177 FIRST!
(this includes tests built on the newer configuration)
This is getting a little large, so starting a PR here.
The goal is to create an import widget for an App Cell. This should be a dropdown menu that populates itself by searching for files in the FTP staging area.
The next PR will introduce a mechanism for it to query against dynamic services. But that will likely require some updates to the Narrative Method Store to get the parameters in the App Spec, so it's not yet.
This creates a new parameter type in App Specs called "dynamic_dropdown". This gets interpreted as a string and entered into the Python app running code as a file path. It makes use of Select2, so that when a user clicks the dropdown, it'll do a search against the FTP service (assumes a working FTP endpoint with a '/search/' route) and populate the dropdown based on that search. Also assumes the results are of a specific structure, but that'll also change when this gets adapted for dynamic services.
Still todo on this PR: