Revamp log viewer for apps ran [KBASE-5405] #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briehl
requested changes
Nov 29, 2017
There was a problem hiding this comment.
I think the scrolling still looks a little off, and possibly confusing, but this is a good first step. I like that the arrow buttons reflect the direction of the scrolling now.
Just a few stylistic changes that should get fixed before merging, then we can merge and iterate on the scrolling part.
| if(target.is(':last-child')){ | ||
| target.show(); | ||
| }else{ | ||
| // target.show('slide', {direction: 'up'}); |
There was a problem hiding this comment.
go ahead and delete commented code. that's what git's for. :)
| // target.show('slide', {direction: 'up'}); | ||
| target.slideDown(); | ||
| } | ||
| // $panel.prepend(target); |
| .on('scroll', function () { | ||
|
|
||
| //at begining | ||
| var top = $(this).scrollTop() |
| @@ -943,7 +1060,7 @@ define([ | |||
| ui.hideElement(element); | |||
| }); | |||
| } | |||
|
|
|||
| // Emit messages for this state. | |||
| // if (state.ui.messages) { | |||
| @@ -1005,6 +1122,8 @@ define([ | |||
| fsm.bus.on('on-job-not-found', function(message) { | |||
| doJobNotFound(message); | |||
| }) | |||
| return lines.map(function(line) { | ||
| return renderLine(line); | ||
| }).join('\n'); | ||
| var $section = $('<div/>') |
briehl
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-add scroll function
-nav buttons scroll instead of page
-will only fetch previous log lines on page up or scroll up
-change style of errors
-can expand out the view