-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp log viewer for apps ran [KBASE-5405] #1215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the scrolling still looks a little off, and possibly confusing, but this is a good first step. I like that the arrow buttons reflect the direction of the scrolling now.
Just a few stylistic changes that should get fixed before merging, then we can merge and iterate on the scrolling part.
if(target.is(':last-child')){ | ||
target.show(); | ||
}else{ | ||
// target.show('slide', {direction: 'up'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go ahead and delete commented code. that's what git's for. :)
// target.show('slide', {direction: 'up'}); | ||
target.slideDown(); | ||
} | ||
// $panel.prepend(target); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
.on('scroll', function () { | ||
|
||
//at begining | ||
var top = $(this).scrollTop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs semicolon
@@ -943,7 +1060,7 @@ define([ | |||
ui.hideElement(element); | |||
}); | |||
} | |||
|
|||
// Emit messages for this state. | |||
// if (state.ui.messages) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of what?
@@ -1005,6 +1122,8 @@ define([ | |||
fsm.bus.on('on-job-not-found', function(message) { | |||
doJobNotFound(message); | |||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs another semicolon
return lines.map(function(line) { | ||
return renderLine(line); | ||
}).join('\n'); | ||
var $section = $('<div/>') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs semicolon
-add scroll function
-nav buttons scroll instead of page
-will only fetch previous log lines on page up or scroll up
-change style of errors
-can expand out the view