add 'is_temporary' field to saved narrative objects, not just workspace metadata #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCreosote
reviewed
Jan 6, 2018
| @@ -211,6 +211,7 @@ def write_narrative(self, obj_ref, nb, cur_user): | |||
| meta[u'job_ids'][u'apps'] = list() | |||
| if 'job_usage' not in meta[u'job_ids']: | |||
| meta[u'job_ids'][u'job_usage'] = {u'queue_time': 0, u'run_time': 0} | |||
| meta[u'is_temporary'] = 'false' | |||
There was a problem hiding this comment.
OK, so according to bill in this case, as opposed to the narrative service, Untitled is a fine name for a non-temporary narrative. Saving a narrative here implies that 1) the user has changed the name or 2) the user has run an app. Hence the narrative is no longer empty and not temporary.
Effectively, once the narrative service creates an empty narrative, the front end cannot save temporary narratives.
MrCreosote
approved these changes
Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this needs to do from here (other work is in kbaseapps/NarrativeService) is to ensure that there's an "is_temporary" field in the saved object metadata, and it's set to "false" on save.
The user should be prevented from saving an "untitled" narrative elsewhere.