Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAUP-128: First pass at adding support for a Truss tagged image build, based on branch named "truss" #1836

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

sychan
Copy link
Contributor

@sychan sychan commented Oct 2, 2020

Description of PR purpose/changes

  • Adds several new configs and shell scripts that run via github actions to support a new narrative-truss image that is build from a branch named "truss". This is intended for testing on narrative-refactor.kbase.us
  • We want to keep a parallel test/integration environment for the Truss bulk import/analysis work, instead of having to deploy into CI for testing.
  • We may need some help from Jason Fillman for setting permissions in case we missed something. These edits were tested in the narrative-traefiker repo and worked properly.

Jira Ticket / Issue

Testing Instructions

  • Details for how to test the PR:
  • Tests pass in travis and locally
  • Changes available by spinning up a local narrative and navigating to X to see Y (N/A)
  • Will need to see if the github actions complete without error after the merge (must merge first)
  • Create a new branch called "truss" and make a trivial PR against it, this should result in a new narrative-truss:PR-### being built and visible at https://github.com/orgs/kbase/packages. Upon merge, a narrative-truss:latest should be available

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have run Black and Flake8 on changed Python Code manually or with git precommit (and the travis build passes)

Updating Version and Release Notes (if applicable)

@sychan
Copy link
Contributor Author

sychan commented Oct 2, 2020

Still in draft stage while I make sure nothing breaks.

@coveralls
Copy link

coveralls commented Oct 2, 2020

Coverage Status

Coverage remained the same at 16.327% when pulling 554f20a on trussimage into e1c7368 on develop.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jsfillman jsfillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and was tested on narrative-traefiker prior to this PR.

The change Codacy recommends actually breaks the build, and can safely be ignored.
Should probably look into adding an exception so it'll stop complaining.

This is 👍 to merge.

@sychan
Copy link
Contributor Author

sychan commented Oct 3, 2020

Spoke to Bill, he was okay with merging it to test.

@sychan sychan merged commit 4953ad1 into develop Oct 3, 2020
@sychan sychan deleted the trussimage branch October 3, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants