Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataup187 move globus bug fix #1868

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Conversation

leia-sefkin
Copy link
Contributor

Description of PR purpose/changes

  • Fixing an issue with the previous PR where the script to add ACL
    on line 170 of stagingAreaViewer.js wasn't getting triggered due to a class/element name mismatch

Jira Ticket / Issue

https://kbase-jira.atlassian.net/browse/DATAUP-187

Testing Instructions

  • Details for how to test the PR: I was able to confirm that the call to the ACL service is triggered by logging and checking in the console. However can't quite test fully on CI as the endpoint is disabled for security reasons.

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@bio-boris bio-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged up

@bio-boris bio-boris merged commit 160026c into truss Oct 15, 2020
@bio-boris bio-boris deleted the DATAUP187-move-globus-bug-fix branch October 15, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants