-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataup 187 move globus upload below drag and drop #1855
Dataup 187 move globus upload below drag and drop #1855
Conversation
…bus is not linked
This pull request fixes 1 alert when merging 1d1b9c8 into 2a619e8 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels somewhat disingenuous to review and approve since I wrote a decent chunk of this 😬 but with that caveat it looks good overall to me. Only one small comment about test coverage.
kbase-extension/static/kbase/js/widgets/narrative_core/upload/stagingAreaViewer.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed!
|
Description of PR purpose/changes
This PR moves the upload with globus and upload with url buttons bellow the dropzone. It also edits the text in the drop zone.
![Screen Shot 2020-10-12 at 3 05 10 PM](https://user-images.githubusercontent.com/56279459/95797634-727a9600-0c9c-11eb-96d0-816024b636e7.png)
Jira Ticket / Issue
https://kbase-jira.atlassian.net/browse/DATAUP-187
Testing Instructions
Unit tests: execute
make test-frontend-unit
To view changes locally:
kbase-narrative
Dev Checklist:
Updating Version and Release Notes (if applicable)