DATAUP-246: CSS cleanup, pt II #1879
Conversation
ialarmedalien
requested review from
bio-boris,
briehl,
leia-sefkin and
eamahanna
| @@ -105,17 +99,14 @@ | |||
|
|
|||
| .kb-app-cell .kb-app-parameter-row .message.-error { | |||
| background: #f2dede; | |||
| color: #f44336; | |||
There was a problem hiding this comment.
moved from line 115
| @@ -188,6 +169,7 @@ control with padding, and then scooting the icon back into its column. | |||
| color: #777; | |||
| text-align: left; | |||
| margin-top: 3px; | |||
| padding-left: 7px; | |||
There was a problem hiding this comment.
moved from line 179
| .kb-app-cell .kb-app-subtitle { | ||
| background-color: #f5f5f5; | ||
| padding: 3px 5px; | ||
| } |
There was a problem hiding this comment.
duplicate stanza
| .btn.kb-app-cell-btn.btn-danger.active:hover { | ||
| color: rgb(209, 82, 65); | ||
| background-color: #ddd; | ||
| border-bottom: 2px rgb(209, 82, 65) solid; | ||
| margin-bottom: 4px; | ||
| } |
There was a problem hiding this comment.
duplicate stanza - see line 415 in old version / 392 in new version
| @@ -77,7 +77,6 @@ | |||
| } | |||
|
|
|||
| .panel.kb-panel-light .panel-body { | |||
| padding-top: 0; | |||
There was a problem hiding this comment.
overridden in next line
| /* Set a plain default color -- should be overridden when building the button. */ | ||
| .btn.kb-flat-btn { | ||
| color: #666; | ||
| } |
There was a problem hiding this comment.
combined into stanza starting at line 4
| .btn.kb-flat-btn:hover { | ||
| background-color: #f5f5f5; | ||
| } |
There was a problem hiding this comment.
overridden by stanza starting @ line 50 (line 22 in new version)
| text-decoration-style: solid; | ||
| text-decoration-color: red; |
There was a problem hiding this comment.
not valid css
| #kblog-msg { | ||
| margin-top: 5px; | ||
| } |
There was a problem hiding this comment.
combined with next stanza
| .view-header { | ||
| font: 1.5em/1.75em 'RobotoBlack', Arial, sans-serif; | ||
| font-weight: normal; | ||
| color: #898989; | ||
| letter-spacing: 0; | ||
| } |
There was a problem hiding this comment.
duplicates the previous stanza
| -moz-transition: box-shadow 0.2s ease-in-out; | ||
| -o-transition: box-shadow 0.2s ease-in-out; | ||
| transition: box-shadow 0.2s ease-in-out; | ||
| -webkit-box-shadow: 0 1px 2px #aaa, 0 5px 5px #aaa; | ||
| -moz-box-shadow: 0 1px 2px #aaa, 0 5px 5px #aaa; | ||
| box-shadow: 0 1px 2px #aaa, 0 5px 5px #aaa; |
There was a problem hiding this comment.
reordering as the unprefixed version should go last
| #notebook { | ||
| padding: 0; | ||
| } | ||
|
|
||
| span#notebook_name { | ||
| #notebook_name { | ||
| color: #006698; | ||
| } | ||
|
|
||
| span#notebook_name:hover { | ||
| #notebook_name:hover { |
There was a problem hiding this comment.
should not require a tag if there is an ID
| @@ -165,7 +164,7 @@ span#notebook_name:hover { | |||
|
|
|||
| .btn-toolbar { | |||
| margin-left: 0; | |||
| padding-left: -5px; | |||
There was a problem hiding this comment.
cannot have negative values for padding
| @@ -128,21 +128,21 @@ body { | |||
|
|
|||
| strong, | |||
| b { | |||
| font-family: 'Oxygen'; | |||
| font-family: 'Oxygen', Arial, sans-serif; | |||
There was a problem hiding this comment.
Adding in fallbacks
| @@ -7,10 +7,6 @@ | |||
| z-index: 1000; | |||
| } | |||
|
|
|||
| body { | |||
There was a problem hiding this comment.
moved into body stanza at line 27 in new version
| @@ -23,56 +19,40 @@ body { | |||
| } | |||
|
|
|||
| html { | |||
| background-color: #a2a2a2; | |||
There was a problem hiding this comment.
Overridden at (old) line 31
| box-shadow: none; | ||
| moz-box-shadow: none; |
There was a problem hiding this comment.
invalid -- converted to -moz-box-shadow throughout
| @@ -585,7 +514,6 @@ img.dataset-cell { | |||
| background-image: url("../images/gears.png"); | |||
| background-position: right; | |||
| background-repeat: no-repeat; | |||
| #background-color: #f2f2f2; | |||
There was a problem hiding this comment.
invalid syntax for css
| @@ -682,7 +610,6 @@ div.metadata { | |||
|
|
|||
| div.social { | |||
| float: right; | |||
| display: block; | |||
There was a problem hiding this comment.
overridden three lines later
| @@ -696,7 +623,7 @@ p span.notification { | |||
| } | |||
|
|
|||
| /** | |||
| * Bootstrap 3 submenu hack^H^H^H^H fix | |||
| #menubar .navbar { | ||
| margin-bottom: 5px; | ||
| } |
There was a problem hiding this comment.
combined with #menubar .navbar at (old) line 833
| @@ -80,13 +80,13 @@ | |||
| line-height: 18px; | |||
| text-align: center; | |||
| text-transform: uppercase; | |||
| color: #4379B1; | |||
| color: #4379b1; | |||
There was a problem hiding this comment.
stylelint, the css formatter I have been using, lowercases all the colour lettering.
| } | ||
|
|
||
| .kb-data-list-drag-target.-drag-hover { |
There was a problem hiding this comment.
combining stanzas
| -webkit-box-shadow: none; | ||
| moz-box-shadow: none; |
There was a problem hiding this comment.
invalid - corrected to -moz-box-shadow throughout
| -webkit-box-shadow: none; | ||
| moz-box-shadow: none; | ||
| xfont-size: 18px; |
| @@ -1075,7 +1068,6 @@ div.metadata { | |||
|
|
|||
| div.social { | |||
| float: right; | |||
| display: block; | |||
There was a problem hiding this comment.
overridden a couple of lines later
| #menubar .navbar { | ||
| margin-bottom: 5px; | ||
| } |
There was a problem hiding this comment.
combine with stanza at (old) line 1209 / (new) line 1197
| .kb-method-parameter-hint { | ||
| padding-left: 7px; | ||
| } | ||
|
|
There was a problem hiding this comment.
combine with stanza at (old) line 2019 / (new) line 1992
|
|
||
| --webkit-box-shadow: 1px 1px 1px 1px #fff; | ||
| --moz-box-shadow: 1px 1px 1px 1px #fff; |
There was a problem hiding this comment.
another variation on the theme of "wrong"
| @@ -3241,8 +3191,7 @@ button.kb-data-obj { | |||
| } | |||
|
|
|||
| .kb-nar-manager-titles { | |||
| font-family: "Oxygen"; | |||
| font-weight: bold; | |||
There was a problem hiding this comment.
repeated at line 3250
| .kb-import-info { | ||
| font-weight: normal; | ||
| } |
There was a problem hiding this comment.
combine with stanza at (old) line 3363 / (new) line 3302
- removing commented-out styles - removing invalid css tags and values - removing duplicated stanzas - combining declarations spread over several lines
ialarmedalien
force-pushed
the
DATAUP-246_css_to_sass_css_clean_up
branch
from
50909a4
to
0c43d4e
Compare
|
SonarCloud Quality Gate failed.
|
|
@eamahanna thanks for the review! I am going to address the codacy/sonarcloud issues in another PR; trying to keep these PRs to a single type of fix to make it easier for reviewers. This one is just removing comments, invalid CSS, and duplicated code. Next PR (or PR after that) will fix some of the codacy issues, like not having fallbacks for font declarations. |
NOTE: this is built on top of the whitespace changes made in #1872. When #1872 is merged, I will rebase this PR.
Description of PR purpose/changes
The changes made in this PR include:
Jira Ticket / Issue
https://kbase-jira.atlassian.net/browse/DATAUP-246
Testing Instructions
Dev Checklist: