DATAUP-246: whitespace changes and reformatting of css files #1872
Conversation
ialarmedalien
requested review from
bio-boris,
briehl,
leia-sefkin and
eamahanna
|
SonarCloud Quality Gate failed.
|
| margin-left: 10px; | ||
|
|
||
| /* Not a link anymore, so we disable for now | ||
| cursor: pointer; */ |
There was a problem hiding this comment.
in the spirit of cleaning up comments should we get rid of this as well?
| margin: 2px; | ||
| margin-left: 10px; | ||
|
|
||
| /* cursor:pointer; */ |
| color: #FFF; | ||
| background-color: #FFF; | ||
| text-shadow: none; | ||
| /* like mayo on wonderbread */ |
| /*background: #eeeded;*/ | ||
| margin: 0 auto; | ||
|
|
||
| /* background: #eeeded; */ |
| font-size: 1.1em; | ||
|
|
||
| /* max-height: 2.6em; | ||
| overflow:hidden; */ |
There was a problem hiding this comment.
some more commented out cruft
| font-size: 2em; | ||
|
|
||
| /* max-height: 2.6em; | ||
| overflow:hidden; */ |
| /* overflow-x: hidden; | ||
| overflow-y: auto; */ | ||
|
|
||
| /* height: 830px; */ |
| display: inline-block; | ||
|
|
||
| /* background-color: #2196F3; | ||
| color: #BBDEFB; */ |
There was a problem hiding this comment.
Tried reviewing as best I could. Running locally everything looks normal (or as best as I can test with prod services and staging down). Looks like there's some comments trailing in a few of these files that we could clean up (if you still have the energy after this monster) flagged a few that I saw.
|
|
||
| /* .container { */ | ||
|
|
||
| /* max-width: 2000px !important; */ | ||
|
|
||
| /* } */ |
| .nav > li > a:focus { | ||
| text-decoration: none; | ||
|
|
||
| /* background-color: #fff !important; */ |
| /*margin: 15px 7px 0 0;*/ | ||
| display: inline-block; | ||
| padding: 0 15px 0 0; | ||
| /* margin: 15px 7px 0 0; */ |
| /* #select-box tr :hover { | ||
| background-color: #eee; | ||
| }*/ | ||
| } */ |
There was a problem hiding this comment.
another one we can get rid of?
| } | ||
|
|
||
| /*div::-webkit-scrollbar { | ||
| /* div::-webkit-scrollbar { |
There was a problem hiding this comment.
Can we get rid of this chunk too? 130-145 (tried multi-line comment and for some reason it wouldn't)
| } | ||
|
|
||
| header[role="banner"] { | ||
| /* overflow: auto; | ||
| /* overflow: auto; | ||
| padding: 7px 0 2px 0; |
There was a problem hiding this comment.
this chunk as well and just below have some comments we can get rid of
| nav[role="navigation"] ul { | ||
| margin: 1.2em 0 0.5em 0; | ||
|
|
||
| /* text-align: center; */ |
| position: absolute; | ||
| top: 55px; | ||
| bottom: 5; | ||
| /* width: 1170px; */ |
| /* float: left; */ | ||
|
|
||
| /* max-width: 1170px; | ||
| */ |
| } | ||
|
|
||
| /*.left-pane { | ||
| /* .left-pane { | ||
| font-size: 14px; |
There was a problem hiding this comment.
some more comments we could remove here and generally in this file
|
@ialarmedalien I tested this out locally, worked fine. It's up to you if you'd like to merge it in or delete more cruft this pass. |
|
@ialarmedalien Also there are a bunch of sonarcloud issues which are an easy fix, adding a default font family |
|
@bio-boris I'll add them in a later PR. This one is almost entirely whitespace changes. |
Description of PR purpose/changes
Ran the stylelint css formatter/linter over the codebase to enforce whitespace and formatting; stylelint is one of the code quality checks run by Codacy.
In addition to formatting the css, stylelint also identified a number of empty stanzas, which I removed.
Jira Ticket / Issue
https://kbase-jira.atlassian.net/browse/DATAUP-246
Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)