Remove old NarrativeManager.js

[briehl]

Description of PR purpose/changes

The functionality in kbase-extension/static/kbase/js/api/NarrativeManager.js has long since been moved to remote NarrativeService calls. @dauglyon encountered this earlier, and I was reminded that it wasn't actually removed from this repo's codebase. Oops.

This PR fixes that by removing the module and dangling references to it. It's only imported in one module, and there it's just initialized and never used.

Testing Instructions

• Details for how to test the PR:

• Tests pass in travis and locally
• Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

• My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have run Black and Flake8 on changed Python Code manually or with git precommit (and the travis build passes)

[ialarmedalien]

deliberate?

[briehl]

Oh. Forgot about that.

Uh, semi-deliberate. It doesn't affect anything except for a dev downloading the module. Running locally against narrative-refactor doesn't seem to work for me.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

[lgtm-com]

This pull request fixes 1 alert when merging 6113662 into 498b63c - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[ialarmedalien]

LGTM

[briehl]

Once Travis testing passes, I'll merge.

[coveralls]

Coverage increased (+0.05%) to 16.373% when pulling 6113662 on remove-narrativemanager into 498b63c on develop.