Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message configurable upon assertion failiure #22

Closed
kbilsted opened this issue Apr 1, 2015 · 0 comments
Closed

Make error message configurable upon assertion failiure #22

kbilsted opened this issue Apr 1, 2015 · 0 comments

Comments

@kbilsted
Copy link
Owner

kbilsted commented Apr 1, 2015

Currently, the assert error message is hard-coded. We need to introduce an abstraction that given the "new" and "old" values used in the assert along with the message provided in the assert and the escaped "new suggested value" for the assert-rewrite

e.g. something

string CreateAssertMessage(
  string actual, 
  string oldExpected, 
  string escapedNewExpected)

and provide a default behaviour that shows the full old and new values for the assert

The CreateAssertMessage should be configurable through the Configuration class.

@kbilsted kbilsted assigned kristianhald and unassigned kristianhald Apr 1, 2015
kbilsted added a commit that referenced this issue Apr 2, 2015
Also moved Configuration setters related to testing to a separate test instance

closes #22
@kbilsted kbilsted added this to the 2.1.x milestone Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants